Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1269116imm; Fri, 27 Jul 2018 14:14:08 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdC2viyvBFMCx/k+kryfgsIohgP8yMnoayCl3Uv/FuWk4iq/iStYI/e96wgZcjabNKgEzHA X-Received: by 2002:a62:3703:: with SMTP id e3-v6mr8211533pfa.117.1532726048293; Fri, 27 Jul 2018 14:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532726048; cv=none; d=google.com; s=arc-20160816; b=qzGEPu3l/FEZbVqzX/DFeouLH9BwypcBdUqTDcWdCdT/uk52wYQZsOdf/Hfe+LckCP TZHI/x8kZm6+SWZWGd/dj4dlaYq+vdZ2RqnsW6cR3CIw/5ix6racx3pDRF7Tgxa2AliH vBAnwK9saWZYJXGRB6skRlhqD2ZDXcDiCrhocH3/a6rpWa367JuUA1ck2tmel0IJ5rCM UrGexghgZdbhPhM0rtghiygyYNtuEECD3KbjbxDp79hSLI6KUcw78qqVrOfT6aZpPwst HMCoBjPyuWCnCYf4GYv2a8tAlX5IEE1rBAPrXbGJSFfKk1DN9d0wBV0PKwGF/QQeYAdU o6zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=c5LTMrCh2DWwvyVnSwabCLFvxUcLLXlQiPVW4PqtW6Q=; b=Y50FMuZDyn1r0u1xlZIiQTMBrhy5x/bbMPaDWCobx/if9ZRrh+7WHZbz3+wvph3ZAI GUMo08tDnl2yo21/hYm1KlcWmA2GKcVCaCF365sd1Nzga9/LOx0SKCtMktFVsjJd1AUQ q8I8TEcfUmgFkKEKuyLsdhjM34MmhyPFJJP94saMwKIbOXBGVggOos7kRAZ8dJVCuXGk Z3AeYr8HzNW4SfS+sEGY7qr2+Iq9llO9f5vnUFw14nPAjwaJdeP/oPICkzuiM0PUM7Dd pu2XqjDfmBxwvCUZe+u3P+nLxLmFeIZcCDw8lgqRZCibw1+yp+XlWg+Db7ZE++n85iBq IhDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18-v6si4111692pgp.467.2018.07.27.14.13.54; Fri, 27 Jul 2018 14:14:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389804AbeG0Wg2 (ORCPT + 99 others); Fri, 27 Jul 2018 18:36:28 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389791AbeG0Wg2 (ORCPT ); Fri, 27 Jul 2018 18:36:28 -0400 Received: from localhost (unknown [172.56.44.110]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E639C108A9043; Fri, 27 Jul 2018 14:12:45 -0700 (PDT) Date: Fri, 27 Jul 2018 14:12:42 -0700 (PDT) Message-Id: <20180727.141242.2216331524901553805.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() From: David Miller In-Reply-To: <20180727083425.14481-1-baijiaju1990@gmail.com> References: <20180727083425.14481-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Jul 2018 14:12:48 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 16:34:25 +0800 > m88e1116r_config_init() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.