Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1269494imm; Fri, 27 Jul 2018 14:14:36 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfwg5GgLLRapG8JucRdsuNAQDaparivLcl5PrTe9mZwjCa0cYx8/1b0P3PmoIdqgcKj7o70 X-Received: by 2002:a17:902:bd07:: with SMTP id p7-v6mr7601935pls.32.1532726076087; Fri, 27 Jul 2018 14:14:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532726076; cv=none; d=google.com; s=arc-20160816; b=laUKp+WzOc7iEXtR4Gq0WKVuEx5UCyJamlAoIKtXYoDFRCrCK6UPEmNLn7slsB97o3 zFb4Dn1kkxU0Ab7djK3FR4lfzRXzyNwDfgw0e4NsKNRHRInq4dfWvpEHA15EwkuOke+4 OuKI9+3zAvdCPtggnx7RdZQ6n/ve3yPaTn4QTRiVsW/UWnD6cJTyJM8rME8hMwZyDaMo yiPfXHY4gYPEW2b10qARXDSa6bJVi6bYoquY+PPAFgkx92PQChd+O1OjhZTdrmN+K5jI rljni5onj42qXjkGwWXofNIn09tBwhM1gfa5TbGGQ+7R20QO1DbkP+W32fCpK1p5vABa WCJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=dEn2U7yQ1pNUk6SyBiKgIp8YvswIk4mrzo/zRgF4KY0=; b=H+qQHaNihlaT1Ar8KavN/kp8NLFSfBsgbEcamxjL9XO9Msb2Gv2n/j30hfq7NekQHJ Yy+dcTEwOZtTNKXC1VtWKvH9DPMAfjhefPSrO3Nuzvz794Fl6yg1ypPVw+VRKggovp2w V+jw5H0OEeZ+zAZiF4vgcbhqECN1fA9r9u3Rbvo8Dl2WngsI5LmiUnEZXNVBYlIrE/ZW Dmeu/PHmV15WgpFzftM2NkbPyZGRn5X3Tt3tNFm+cEzFEKGg2af4i5b5Mv+0Q3Q1SMCr rhhV6GYyBbI4CtzhDYrO2L/hHDszHOedF5f4+hFV49AdAeMo+WApuKzJJhJK3m802U80 mbuQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si4194917pli.431.2018.07.27.14.14.21; Fri, 27 Jul 2018 14:14:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389870AbeG0Wgu (ORCPT + 99 others); Fri, 27 Jul 2018 18:36:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39212 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389857AbeG0Wgu (ORCPT ); Fri, 27 Jul 2018 18:36:50 -0400 Received: from localhost (unknown [172.56.44.110]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0EA32108A9043; Fri, 27 Jul 2018 14:13:07 -0700 (PDT) Date: Fri, 27 Jul 2018 14:13:05 -0700 (PDT) Message-Id: <20180727.141305.435897896785120145.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: jon.maloy@ericsson.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tipc: name_table: Replace GFP_ATOMIC with GFP_KERNEL in tipc_nametbl_init() From: David Miller In-Reply-To: <20180727092825.7370-1-baijiaju1990@gmail.com> References: <20180727092825.7370-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Jul 2018 14:13:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Fri, 27 Jul 2018 17:28:25 +0800 > tipc_nametbl_init() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Applied.