Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1313631imm; Fri, 27 Jul 2018 15:10:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeHhNjqJFALcc68VAO7e2S/vuxMVMVIs2jAjbNHFo+zALqJnUgevNsKIDgPFd5R+xtBIoXB X-Received: by 2002:a63:4811:: with SMTP id v17-v6mr7492147pga.379.1532729444162; Fri, 27 Jul 2018 15:10:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532729444; cv=none; d=google.com; s=arc-20160816; b=noGAyxL/Pik+KVTznUKlq4BvL/LHNfgpbdtNKxKZcj9vJGxTOKI5y5rVJHNh9LWlYR oTuk2rIhdU7FteyJy92F7EDQMGx3HPKDW2bIqN4tvzNNajpfHmhhSCFwu5/VUUurPZLl OWwZvGCXh7/hRujfyJTdaXk1xmdst491HUeYmdh/uNrqzvfz2lmGdu2nmcN8w3ISkTYB D0JsQ3brHZrfnXrfIbmLdfl+c4BNyXNWvvJUZqyokclsV55/h/8gBSj2BQspa4/YTcUN QgHvK3+ZYgL7xsD4JwhYeQ2hF/M08JZVy6RJBglJvOW0Or4yND8/AgOrMhrg8D54qLeO lPLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=ff77+7yohY+ThSdIWsfINlin5l6KyyVVQY/vjyKzlwo=; b=aj7Y5fUGXYiep1dKOyB2VXKk2hKZG5YU5J+qu3hEriLrQEtmnQK8yKbXJVLxjPKK+G 05+xPA9SXfu49Sm4sjZgJFoIGEAVLCNyRUTqGP930q8IWzDz9Hrr+ujzjozdg2AwRwB/ La9jisQjrJFyS2SxfanlMf9Bo/JJlmiOgAEvVTPprZ2dxVQpN48GWufjA+XuBJVnd9if zab7GdbfhKC9vj5B6UIczTn8UdPUobozoVxrYQeF/X/d2tm2DqmI+U/hldhegKzJ1H5j yYNGwuFIhyFT1+bdSJiwbC4NmwoJhrV4Iv2bLByQpc2n/peg/24ccjCYMjG31h9b6F5A 1MUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1-v6si4319478pld.11.2018.07.27.15.10.29; Fri, 27 Jul 2018 15:10:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389101AbeG0Xdg (ORCPT + 99 others); Fri, 27 Jul 2018 19:33:36 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36140 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728656AbeG0Xdg (ORCPT ); Fri, 27 Jul 2018 19:33:36 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D75A7DAC3; Fri, 27 Jul 2018 22:09:42 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-116.rdu2.redhat.com [10.10.120.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id A2FFF10FFE6C; Fri, 27 Jul 2018 22:09:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <153271267980.9458.7640156373438016898.stgit@warthog.procyon.org.uk> <153271288242.9458.18050138471208178879.stgit@warthog.procyon.org.uk> To: Andy Lutomirski Cc: dhowells@redhat.com, Al Viro , Linux API , Linus Torvalds , Linux FS Devel , LKML Subject: Re: [PATCH 30/38] vfs: syscall: Add fsmount() to create a mount for a superblock [ver #10] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9159.1532729381.1@warthog.procyon.org.uk> Date: Fri, 27 Jul 2018 23:09:41 +0100 Message-ID: <9160.1532729381@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 27 Jul 2018 22:09:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 27 Jul 2018 22:09:42 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski wrote: > int mfd = fsmount(...); > > where you pass in an fscontext fd and get out an fd referring to the > root of the filesystem? In this case, maybe fs_open_root(2) would be > a better name. It's not necessarily the root of the filesystem in the sense of sb->s_root. It might be a subset of that, or it might be a part of a filesystem that might have multiple roots because it doesn't know where the real root is (NFS2, for example). > This *definitely* needs to be clearer in the description. I'm open to suggestions of better wording. It's a bit hard to explain because, as you pointed out, the terminology is overloaded. David