Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1400872imm; Fri, 27 Jul 2018 17:09:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfQ+M8+dBOppenECODiimkjas85Mk3Cdd/comD0CpX99of+c9ckyyiZP35qNUvtj2T3fS4a X-Received: by 2002:a65:6551:: with SMTP id a17-v6mr7895792pgw.132.1532736599402; Fri, 27 Jul 2018 17:09:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532736599; cv=none; d=google.com; s=arc-20160816; b=WSOiN5UnoatqP1Mt92g4qoFfZW1iemn5dFJabUf4Ne0YfXtZjX0W+wNJdNLf14qbDZ UECqgpTCfCm2VBeOSEIzakuVLHC8RJx+9q9bNJC25FfMtPY04pb7QlZoedImLXhjI2GT BIWfqikOG4PKmV+iWNiP6XFazeMbfYzH49Xy+IzpGzmqnErXPiBg7c4+TnXTa/7h9Bld SkgrCOzR7hhzXe+NpwUmaJN3LvM5nQZBLwW8B3cM9a6l7/+U6y6elgZvJH0wpmESnsVS 91s8z0jTouXeWyeHkDjiIGRl0hjAwEwCzWJZgQG8g1YigvXxz/S2ZbISOO+uNdzPIO9M kybg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=jcayA0fMXa02C9CITZc1P19AU1HQWa1Nz/lKTcD5O6c=; b=BRbbQCjFRuqeQ9OsE4FtEj+/cCmat5pk7vHGFREOc1CpYxHYhN9W8yLkxW7Xdc8LDe SywhR5syFr0yyJks3tPdL4Tfs0Vk/fNGBXldj8068U+TF7SYxAOvZpQ3VQrLsu+LQ2W/ raekTbxnGvLZYR0LrB6FAat4fg070dM1t0tFxO0AAjT9ffuguYIiV0ZhA+5DqCREayJj LZjCbmRmLIgdFTWwMlw4NFNz/2OF51iDPovr/iwomKkipgRjRQwxcYzpt7zpNNbZuDQE X8oefn5v3ZsBQ0HNwidtchF3Uv0DP4qwXA69X67D3O9V4m/RfKwEcnWihwtV6OrqBmRe FQZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w37-v6si4959374pgl.514.2018.07.27.17.09.44; Fri, 27 Jul 2018 17:09:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389228AbeG1BdO (ORCPT + 99 others); Fri, 27 Jul 2018 21:33:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52962 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731568AbeG1BdO (ORCPT ); Fri, 27 Jul 2018 21:33:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 185B440216E8; Sat, 28 Jul 2018 00:08:58 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-116.rdu2.redhat.com [10.10.120.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20C6E111AF20; Sat, 28 Jul 2018 00:08:57 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <153271267980.9458.7640156373438016898.stgit@warthog.procyon.org.uk> <153271291017.9458.7827028432894772673.stgit@warthog.procyon.org.uk> <21395.1532735340@warthog.procyon.org.uk> <21746.1532735504@warthog.procyon.org.uk> To: Jann Horn Cc: dhowells@redhat.com, Al Viro , Linux API , Linus Torvalds , linux-fsdevel@vger.kernel.org, kernel list Subject: Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24078.1532736536.1@warthog.procyon.org.uk> Date: Sat, 28 Jul 2018 01:08:56 +0100 Message-ID: <24079.1532736536@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 28 Jul 2018 00:08:58 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 28 Jul 2018 00:08:58 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jann Horn wrote: > > fs/fat/inode.c: sprintf(buf, "cp%d", sbi->options.codepage); > > sprintf(buf, "cp%d", sbi->options.codepage); > sbi->nls_disk = load_nls(buf); > if (!sbi->nls_disk) { > fat_msg(sb, KERN_ERR, "codepage %s not found", buf); > goto out_fail; > } Sorry, yes. I was reading the print as the part of the display of superblock parameters. David