Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1685283imm; Sat, 28 Jul 2018 00:24:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdwuPW1VyC/zqmZjr150D8tBewiPJZQyDbuqziF+6Vz0qzc9EN0qcK4Dhef3lWpDLZLDILl X-Received: by 2002:a63:1315:: with SMTP id i21-v6mr8861349pgl.147.1532762657879; Sat, 28 Jul 2018 00:24:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532762657; cv=none; d=google.com; s=arc-20160816; b=B7WOrkr6vbvzl+mDjKpext7+BtDu21O+qFn9khfW/sOtu94S9HFNxVX//oAs1t4whn oJhmypl8avlTVnszsZk0NihrDNOeoMJXQ+eH7IUp6RXs3hcAPvCLlNYiZylyZVkhicDR mdFXzs5V5cCPMPYiYQnMlz7Jw0fATH8ZdKNhA4Fj4vsw7jHoynQsDxPnwgOu66bEcME9 rbLeLEPTPxeLmuDlgGZzcprrZigVNDPlkzEIZMwSleyPmFqeqfYx3HhrCQV00fH1Ghmj C1vryvE3/Nfl9ahHNkTUvX7HRNcO4CGfRmcZSGzN/vU5NxGCUIkrCfNsJYrhdcxra0zw eKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=QXnym+O7SVWtY6H8t7CqutNLOrKpIFR0bjAvQcRTLgY=; b=t8N0qdwMLG7kawu81BxYGFWUncHtX7WYoh06HQlwyRLdXM7SlhLEIPySQq9qW0AJvH 4yvjMpZN0+pzCkDvjPn7CwiSTFlyrTz6ig4MWqs7qPtjFRB7/b5toEMIEwY6UmMnwFQf guq2JdeDCnvOUoYK4S7HZYw1ASnLKW67GEPJeJk+jaAl/p+1ViT/ZqoHydBF37N2RsdR SsAfkm9cSMa2PSjv+HGwQOtj3OtDOelMjKLGqzYMWqgzxIYFe8/cmD4ZmgHFcf02b1k1 iRNAPdfI+npfEgHEvFHt3Si6Tz/9oCY2oDNe5LAI8HAM8AehWg/H+tRiErClf0YMJxDp ntMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4-v6si5741090pge.173.2018.07.28.00.24.03; Sat, 28 Jul 2018 00:24:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbeG1Iss (ORCPT + 99 others); Sat, 28 Jul 2018 04:48:48 -0400 Received: from smtp2.it.da.ut.ee ([193.40.5.67]:57982 "EHLO smtp2.it.da.ut.ee" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbeG1Isr (ORCPT ); Sat, 28 Jul 2018 04:48:47 -0400 Received: from math.ut.ee (unknown [IPv6:2001:bb8:2002:2400:5054:ff:fe3b:8db9]) by smtp2.it.da.ut.ee (Postfix) with ESMTP id 713379001B; Sat, 28 Jul 2018 10:23:15 +0300 (EEST) Received: by math.ut.ee (Postfix, from userid 1014) id 57D87220922; Sat, 28 Jul 2018 10:23:13 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by math.ut.ee (Postfix) with ESMTP id 5870B220905; Sat, 28 Jul 2018 10:23:13 +0300 (EEST) Date: Sat, 28 Jul 2018 10:23:13 +0300 (EEST) From: mroos@linux.ee To: Wang YanQing cc: daniel@iogearbox.net, ast@kernel.org, davem@davemloft.net, illusionist.neo@gmail.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, netdev@vger.kernel.org, Linux Kernel list , arnd@arndb.de Subject: Re: [PATCH] bpf, x32: Fix regression caused by commit 24dea04767e6 In-Reply-To: <20180725164611.GA12441@udknight> Message-ID: References: <20180725164611.GA12441@udknight> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Commit 24dea04767e6 ("bpf, x32: remove ld_abs/ld_ind") > removed the 4 /* Extra space for skb_copy_bits buffer */ > from _STACK_SIZE, but it didn't fix the concerned code > in emit_prologue and emit_epilogue, and this error will > bring very strange kernel runtime errors. > > This patch fix it. For the record: Tested it on top of 4.18.0-rc6-00192-g864af0d40cdc on the affected machine and it worked. -- Meelis Roos (mroos@linux.ee)