Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2031844imm; Sat, 28 Jul 2018 07:53:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfT714nPNf86BDMDikhB2KRFaiVnY235LknC/Rpn02+IaE5A/8jMGG3OxeWstq394T1wDUK X-Received: by 2002:a62:4bc6:: with SMTP id d67-v6mr10813950pfj.175.1532789638524; Sat, 28 Jul 2018 07:53:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532789638; cv=none; d=google.com; s=arc-20160816; b=YURmt3WsbxPSuEmanZHun6Sy/f7Ul1IiVpVz61AIhybVG6ktBwScCgoJbtk5auU3bu mhFSkzSnlBcMvT+BBE6XpT3u52d3pl8mcUvvgvJiu6KC7BJEKGQ3jU4o0ADbe75Yfs6u 12ZSPJ4R5YxD4FwP91EQDhPBzZqgKE/vSz8wLIdKG04zovjSiSyPWDFghj/HWHbZto3u ccZRutNsoeKgmM7fmWuBxxaUkONdHMO+qtRwJHzgLJz7Fk3zn9CyBSd1qHpcYYvT29q9 zu22e/cxwEb+yED1lWN0grnFinjrQw5sR49j2eWhLqzoZMDNO89Qe7bAB7Mn6T+oJiG5 DyuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=I3ofqcDLbuGfv6YlY2GBrXKDJFCiPS7kLEjcCKbuLOo=; b=KEKYSL6a0UJvs6UQ4V514JGXKczZM0AserZ7oYp26JEcecbVxje0yeO4kJZP1tcCKS HAwtLA496EcnCH+E1LqUQlLEFWLYntFSZe65pHORu2olRUFQNoJ5YKIj5Q3MhVPMJmgT mP8/fjUjNMGnZMbf02j8B5CoDYA85qz4DLB0iu7dc0rVEDOfgiWvgtvOpU0k1/oVIvn8 ExoF6N2bJho+EwzOa//RVh7OTBiFPRn94w76eW1dTiCmGIJalnD0o1CiqncNMm+AM3gJ 97YzSTjIeiVA7iLEYKtWdV4C1EpkBr2ein+RaURDbA/1C9VAXiN8tPWN98GwTenBcykl ee2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z2-v6si5857997pgp.681.2018.07.28.07.53.21; Sat, 28 Jul 2018 07:53:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729047AbeG1QSC (ORCPT + 99 others); Sat, 28 Jul 2018 12:18:02 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33884 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728996AbeG1QSC (ORCPT ); Sat, 28 Jul 2018 12:18:02 -0400 Received: from localhost (D57D388D.static.ziggozakelijk.nl [213.125.56.141]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id B8B7AC77; Sat, 28 Jul 2018 14:51:15 +0000 (UTC) Date: Sat, 28 Jul 2018 16:51:12 +0200 From: Greg KH To: rkir@google.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] tty: Make constants to be enums instead of #define in goldfish.c Message-ID: <20180728145112.GA12252@kroah.com> References: <20180725005133.107823-1-rkir@google.com> <20180725005133.107823-2-rkir@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725005133.107823-2-rkir@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 05:51:32PM -0700, rkir@google.com wrote: > From: Roman Kiryanov > > enums produce better compilation errors than defines. Yes, they can, if you use them correctly. Which you are not doing here, so this patch really does nothing. Why should we take it? confused, greg k-h