Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2031860imm; Sat, 28 Jul 2018 07:53:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdMFgCnXF9PHaeynjTWN7pNNrTHlbbphYlSL2bmsfMbljM7hMN3SaVfrwwHjoJnoYpj5hAM X-Received: by 2002:a62:5984:: with SMTP id k4-v6mr10916114pfj.116.1532789639446; Sat, 28 Jul 2018 07:53:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532789639; cv=none; d=google.com; s=arc-20160816; b=qeqy3FtO2BFkAOjpZ7wI5MNHb9zPaLRdFsZSuPeNlYUAOxyWSXqgmDFo3KoVpkmPqF fmEzxVFTq1JR4+VfafHN+aqqehyj2mvtOH+AoZ0C0N1ooqQ24Dn8U99NaatMRqAgSnhp vJtwgBDybvEE2azffpwKSqUTiBBF4Ns3tPPqRPBQLH3tJwbcvysgt1j9fHBJHMn6w7eL iltzSsaA5Ng0ySEpDhgN0IVa+dl+1VIRjUd/HjBKVcXDsiqCAv2ecwjnQo4dnfBp6SdV kVzHPZWgwh8WROzEpj0GfnqUPVecyWJVMK3C3j0WOWfN70VBS+YkQzoLonvjv2PYXkOS vY6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=yxGfJbFBPdm8fYEVbTRHaQOB28eVMfA0+Wl9ki424Ac=; b=q/sUAASBaLhSR3zjRZRWjkB3593A4QkdvwQjEObTDBFX7ML6SLF9bCt0HH/AeS+p+B 7ktyQC5OeBsbVQy4dEgdT+eWTfP+5zeyqUJS3x5VrKATn+c0O+T/tQ+7zdhjlD83YNQQ RXaPZ/Ka/S9L4mS4bWlnySe2z2RgpCZPISMWwdYevJKhQOqcevyMea2+1bqz/gtMqOg7 Mw+5hOJubn9JMTOxn98Aj4uzUN72Ext5xncPGbEVWK6tWm9Q8zWmuLeAFq2AMGFaKlue RgMuzT6D4TQkof1fShpwuurMRA89V7066Y96/GXjhxMqYvURzW6TPImx/3vv3WIskLi0 zdOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1-v6si7249247pfm.7.2018.07.28.07.53.45; Sat, 28 Jul 2018 07:53:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729082AbeG1QSe (ORCPT + 99 others); Sat, 28 Jul 2018 12:18:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33888 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729040AbeG1QSd (ORCPT ); Sat, 28 Jul 2018 12:18:33 -0400 Received: from localhost (D57D388D.static.ziggozakelijk.nl [213.125.56.141]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 463B1C77; Sat, 28 Jul 2018 14:51:47 +0000 (UTC) Date: Sat, 28 Jul 2018 16:51:43 +0200 From: Greg KH To: rkir@google.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] tty: Address checkpatch warnings in goldfish.c Message-ID: <20180728145143.GB12252@kroah.com> References: <20180725005133.107823-1-rkir@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180725005133.107823-1-rkir@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2018 at 05:51:31PM -0700, rkir@google.com wrote: > From: Roman Kiryanov > > checkpatch.pl complained about missing blank lines > (between variable definitions and executable code) > and using just "unsigned" instead of "unsigned int". That is two different things, please make two different patches. thanks, greg k-h