Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 28 Jul 2018 19:24:48 +0200 (CEST)
From:   Julia Lawall <julia.lawall@lip6.fr>
To:     Joe Perches <joe@perches.com>
cc:     David Laight <David.Laight@ACULAB.COM>,
        'Andrew Morton' <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] checkpatch: check for function calls with struct or
 union on stack
In-Reply-To: <6439210644b66a1847e6fad9205fcc7056319de1.camel@perches.com>
Message-ID: <alpine.DEB.2.20.1807281922420.2964@hadrien>
References: <1236369d28b2f1f5389ff652c4eb89e699e6481e.camel@perches.com>   <20180726122533.104f6eea950853ef50ebc680@linux-foundation.org>   <20180726122807.fad0566951e36d930edb6874@linux-foundation.org>   <9d7441a14897426f8ed5befe8da0cad3@AcuMS.aculab.com>
   <0a6d2ecfacf3786228de664c8e01f6de10314c1b.camel@perches.com>   <9f0377fa74bd4964912ba5a4fc76526d@AcuMS.aculab.com>  <1a75fda0861a0b2bce208fbf9b53785bf0e76fa2.camel@perches.com>  <alpine.DEB.2.20.1807280823200.2466@hadrien>
 <6439210644b66a1847e6fad9205fcc7056319de1.camel@perches.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Sat, 28 Jul 2018, Joe Perches wrote:

> On Sat, 2018-07-28 at 08:25 +0200, Julia Lawall wrote:
> > On Fri, 27 Jul 2018, Joe Perches wrote:
> []
> > > It might make sense for this sort of check to be
> > > added to coccinelle or maybe as a compiler warning
> > > when the struct is larger than some size.
> > >
> > > Original thread for Julia:
> > > https://lore.kernel.org/patchwork/patch/967890/
> >
> > Coccinelle doesn't directly know the size of the structure, but it can
> > count the number of fields.  Maybe a case with an update in the function
> > body
>
> Perhaps this might be the most useful to check.
>
> >  or at least 3 fields is worth reporting on?
>
> a struct with 3 chars or bools might be faster
> by value, but maybe for structs with arrays or
> other structs.
>
> For instance:
>
> lib/vsprintf.c uses struct printf_spec which
> is 16 bytes and that fits nicely in a

This message seems to be cut off.  I got around 70 results, of which 23
are from vsprintf.  Perhaps the simplest would be to print the structure
declaration with the warning message, so the user could easily check the
results.

julia