Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2177379imm; Sat, 28 Jul 2018 10:51:34 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfODHbCKMIOIXJUBb6Dy8L7iAOwshmCvB9Rugieustj5dRu3GDSdYF1XX8I8AAgvxsxrfX6 X-Received: by 2002:a63:6092:: with SMTP id u140-v6mr10471786pgb.433.1532800294680; Sat, 28 Jul 2018 10:51:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532800294; cv=none; d=google.com; s=arc-20160816; b=mGA446vWXqMHMM0JwrozSVZlM40CCdX7i6DWR3HHQ9lIkEy7Xsn5IgDQE31w9eAXVT TisQOWVVIKWR2ssxWlxJeqKi7Y4L027nXN8WJa2suKhxVFlEIwFzqeffdyXJplLOa+pl FJp6Mpg2MwqF80U1RBXB5hD9VsbeECkcuRnsFeREQgPfKmAstVuvS35w4W5qDRUiQPr9 I3oWLHdR6vN3BB2FYvrLnpCgih2sAn7k0Z7NolYixCJXUFN6Mxe175K0X+7YVbScg0Cg tchN/jfIoQjDy7Oi3OUQFIIsifdMAeBsTmUlOZw+XaF1/7AvqN3aAuhD5gkCVPJIklCB y/7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:arc-authentication-results; bh=3GcIO9hKtjhadE1Llxdyg8z8qPIe/5kLRcz8pQLRkgs=; b=NUTP2lTDLa93K8BPT4ImD+fCvHch37s3e1KWrsPzXYLXVAnae+eAFVGa9X+eMb92C3 ve6PhaRijxT5rZfZtjnA5pMXqQejhsLTvBsdIUmnW9/RG/s9R1nJ8+l7V6vnGXAB1Ue6 wZlQYac4aOTmJujVioFZ9+oHhGKDuqV3Q/vrOQgr2V98BiM3kgh2ldlSZHn3Ry2KBA4R egr5trYbZiHdxnuwhVhjDLxpTxFqt6oCaPEeAK3nptuHR1sVc6XckU8Gr6Miirrscslq 1+UV3nUzDHcrbvF+aKVdP8WWRClk3E67KsQ+j9nWIqETX1UcpmC0S/yq5DtgUlYYEzq3 TiiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6-v6si6167144pla.398.2018.07.28.10.51.20; Sat, 28 Jul 2018 10:51:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729575AbeG1TRY (ORCPT + 99 others); Sat, 28 Jul 2018 15:17:24 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39404 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729368AbeG1TRX (ORCPT ); Sat, 28 Jul 2018 15:17:23 -0400 Received: by mail-lj1-f195.google.com with SMTP id l15-v6so7082595lji.6; Sat, 28 Jul 2018 10:50:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3GcIO9hKtjhadE1Llxdyg8z8qPIe/5kLRcz8pQLRkgs=; b=ZD1y7jcSL0FtKpOyBLUBoKseLAf04/sabnWoKbaUN/9v5fOvCRMPCFHC93aJ9G+dEs rr0zER4VH9FV/oZ+qri/hB+J4HV+p/sjjpcHHAKFqpUNAdGH6YmXn8hG3HUj3rYUuPbN FbaysFqMcImL1S3uKmki8b7MAu9cK3ulLTWm5zr/pRWnfZFREoWbmI+twEcAysbBzxGc h9GXMCk+ac+XIWFvgxIJ3aFq+C1t4ifmkm7DdbPgcNIoHDYn58oNnZPE6DxtebX0jOHO XnMsC1FfNujZ/aI/bHJNPoJE8PWiOtOwjWdyFo7B0XPlGHfZ2Fpi4yLzM1iYwPHLhQaU 8xew== X-Gm-Message-State: AOUpUlFkBINwBkvJeg/1IjQ+DY3beIMZeL8gmcT1rmGHckEj/mZ8B0r/ In47TfJ4Yrds4fh+YOvVjEYmGg5L3fI= X-Received: by 2002:a2e:21d5:: with SMTP id h82-v6mr8088146lji.46.1532800205947; Sat, 28 Jul 2018 10:50:05 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id i1-v6sm1226953ljg.43.2018.07.28.10.50.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jul 2018 10:50:05 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id w16-v6so3483167ljh.12; Sat, 28 Jul 2018 10:50:05 -0700 (PDT) X-Received: by 2002:a2e:3313:: with SMTP id d19-v6mr498331ljc.25.1532800205493; Sat, 28 Jul 2018 10:50:05 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:88c2:0:0:0:0:0 with HTTP; Sat, 28 Jul 2018 10:50:05 -0700 (PDT) In-Reply-To: <20180728154007.GA28426@jordon-HP-15-Notebook-PC> References: <20180728154007.GA28426@jordon-HP-15-Notebook-PC> From: Vaishali Thakkar Date: Sat, 28 Jul 2018 23:20:05 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume() To: Souptick Joarder Cc: Laurent Pinchart , airlied@linux.ie, ajitn.linux@gmail.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Linux Kernel Mailing List , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 28, 2018 at 9:10 PM, Souptick Joarder wrote: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). Hi Souptick, Thanks for your patch. > Signed-off-by: Souptick Joarder > Signed-off-by: Ajit Negi > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 ++------------------- > 1 file changed, 2 insertions(+), 19 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 02aee6c..288220f 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -357,32 +357,15 @@ static void rcar_du_lastclose(struct drm_device *dev) > static int rcar_du_pm_suspend(struct device *dev) > { > struct rcar_du_device *rcdu = dev_get_drvdata(dev); > - struct drm_atomic_state *state; > > - drm_kms_helper_poll_disable(rcdu->ddev); > - drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, true); > - > - state = drm_atomic_helper_suspend(rcdu->ddev); > - if (IS_ERR(state)) { > - drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false); I don't think we can use drm_mode_config_helper_(suspend/resume) API here as this file uses CMA functions. And from git grep it seems that there are very few drivers using it at the moment, so not sure if introducing new API functions similar to drm_mode_config will make sense or not. Thanks. > - drm_kms_helper_poll_enable(rcdu->ddev); > - return PTR_ERR(state); > - } > - > - rcdu->suspend_state = state; > - > - return 0; > + return drm_mode_config_helper_suspend(rcdu->ddev); > } > > static int rcar_du_pm_resume(struct device *dev) > { > struct rcar_du_device *rcdu = dev_get_drvdata(dev); > > - drm_atomic_helper_resume(rcdu->ddev, rcdu->suspend_state); > - drm_fbdev_cma_set_suspend_unlocked(rcdu->fbdev, false); > - drm_kms_helper_poll_enable(rcdu->ddev); > - > - return 0; > + return drm_mode_config_helper_resume(rcdu->ddev); > } > #endif > > -- > 1.9.1 >