Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2242375imm; Sat, 28 Jul 2018 12:19:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeOmU6+f/B0CCkB1IUFbPlTVFJnI1IHr4HfcElGIj5U9E1rfHAn9SWWKF2lRcMPGBFAc9vI X-Received: by 2002:a65:64c8:: with SMTP id t8-v6mr10597705pgv.110.1532805568581; Sat, 28 Jul 2018 12:19:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532805568; cv=none; d=google.com; s=arc-20160816; b=KjrKywkEYsk5lIMPSALH+jIs/upyiLYbL+7rXOwnJXWCgAVAUYjeLEXYYix6moApYg LW5xu51fOvB7Sq6OZOIftw7iz16AfvZOKKszsmTrqzrWzF4Y8uK0qp6XXRTeVwh4+lpZ 2quSYjUwx1SHnDL3ShNG96PWCtM3pQcobkbKa762Eiz8/t4FOhYwpr4utgizE5VQ3Pmk l/JOEObb8godFZe3y6tOtGOqdo13RVRWSdzMK+D9iDOpvFFKaqcbxX/Bld0Y1GFyhb4s nHF9LkRMzr2rYjCzzGU8YL/tI9ICOqywKrhakF7xDAjt+ttu7oXx9J4k7qd+QXSL6Oan 8XxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=YmxItEJ9chKiBy4kxYeDKIojKrygw/3nXIvbapRYJ3w=; b=xlBXoV6+lydCwzsAMg5ilN77ooWmuNjfGnwJZPmAK6SBwHNadN2IXjRqhXmbI2RtLP AqUfcZQjMcQKNIAimaGUqtMRbT8b3BY/kuIq5rV6yroJwYqaIkrYywxrX0TcIMM1T7/a 93AA/MnPz825JxtCLWLp2bqoN1HQf/tQrAuq4GkIpfYXD0+B8oeb9mzx+4nsaKzPPDHP X9DuyeNbvpR75oL6jmH7ycQG9cvSbBAbXzTWzmvVTuCzNsziYyYS01XeontFX6DRxLDQ T2ALmY9CvvuUi+9hlMX6S7b6r+0Qw+hZVXVFBnMSj0VC3z/T5c7eenNkXizH712Zr4HG TlxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z17-v6si6352079pgk.183.2018.07.28.12.19.14; Sat, 28 Jul 2018 12:19:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730501AbeG1Upf (ORCPT + 99 others); Sat, 28 Jul 2018 16:45:35 -0400 Received: from www62.your-server.de ([213.133.104.62]:40921 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729227AbeG1Upf (ORCPT ); Sat, 28 Jul 2018 16:45:35 -0400 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1fjUj1-0001L1-5u; Sat, 28 Jul 2018 21:17:59 +0200 Received: from [99.0.85.34] (helo=localhost.localdomain) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1fjUj0-000PKA-OV; Sat, 28 Jul 2018 21:17:59 +0200 Subject: Re: [PATCH net-next] act_bpf: Use kmemdup instead of duplicating it in tcf_bpf_init_from_ops To: YueHaibing , davem@davemloft.net, ast@kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20180728103806.19592-1-yuehaibing@huawei.com> From: Daniel Borkmann Message-ID: Date: Sat, 28 Jul 2018 21:17:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180728103806.19592-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.0/24791/Sat Jul 28 18:42:40 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/28/2018 12:38 PM, YueHaibing wrote: > Replace calls to kmalloc followed by a memcpy with a direct call to > kmemdup. > > Signed-off-by: YueHaibing Acked-by: Daniel Borkmann