Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2318422imm; Sat, 28 Jul 2018 14:19:59 -0700 (PDT) X-Google-Smtp-Source: AAOMgpc9VnWDXFsdZEPAW1bjqQUZApuF9mg8OOVBKkqGuA6bbXecORJdSxXBHcV9Gm9eTNaNX1nE X-Received: by 2002:a65:6343:: with SMTP id p3-v6mr11030785pgv.48.1532812798991; Sat, 28 Jul 2018 14:19:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532812798; cv=none; d=google.com; s=arc-20160816; b=zrys44g/1JRUodNxaSg5Av8DaRgM2d6TCKWsD66Kk8K6FHwvKZRMBpzOD2A2vEqwAV apuohNgaqnBBtib2yEg1idbV+R+j+YKsRPIIYXma2AVtU+czmBfQKlhZoi3JW0BVYmkl ZEUQ4/lc1V173e2gWjUzxq5etPamU4PpyI/nk92xUQkGRrsiGLTKkFV8nFcUTMPVd8I4 6ubo9k1TSOLNDJC8UFvrPxT89DnjSw3KG4ns81GtMv8zhNGTY1gRFC1V6vSpJrkcUQOM MCJ6DEKi2Tv5wdb/XirR187AAazy+30au8aOWbS3F1mkE/eqpGDPhjOdW2Oe+rVX5Az8 k4kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=GYDzRQ0EFjvrmJOiXBb4e36uOnCyWM8BgUcavRi99ao=; b=YRkog6Gvgb8S5gvgBRo7S2TOUXz/JjIo9RPiInupc/M7hPxYfQuj+x25EtKhZN7Qz4 MOPb/S+6B+ydMM40/+3/XbnHzBtUdVSRCT+Q21DpfjwfE9kJYZPhdTe9dPJHJwknGLU8 2VPFm1ESH2sxLtXLC2LpEcMaPQjNlDzvIyRz6W733cM51ogKV5MMA+cxw6NKWghGAQfn uf6PzWw+B9HJmkawQpAUAw6jM7fN/uSgYG1ipuRWdvVcnPTkz4xEK9dPwAP7CZNyV7ze 8HqeJlCskk2vHWfPp/8G1DL8OyLrv4xp1U/xx1vD6444Oo4Xy32yQ9zDQ1c2FdsfJxoV sK7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l26-v6si7009276pfo.325.2018.07.28.14.19.45; Sat, 28 Jul 2018 14:19:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731185AbeG1WqM (ORCPT + 99 others); Sat, 28 Jul 2018 18:46:12 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56338 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730551AbeG1WqL (ORCPT ); Sat, 28 Jul 2018 18:46:11 -0400 Received: from localhost (unknown [172.58.40.57]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1905810150D1C; Sat, 28 Jul 2018 14:18:17 -0700 (PDT) Date: Sat, 28 Jul 2018 14:18:12 -0700 (PDT) Message-Id: <20180728.141812.1026007723536955024.davem@davemloft.net> To: dima@arista.com Cc: nharold@google.com, fw@strlen.de, steffen.klassert@secunet.com, linux-kernel@vger.kernel.org, herbert@gondor.apana.org.au, 0x7f454c46@gmail.com, netdev@vger.kernel.org, luto@kernel.org, ard.biesheuvel@linaro.org, hpa@zytor.com, mingo@redhat.com, john.stultz@linaro.org, kirill.shutemov@linux.intel.com, oleg@redhat.com, sboyd@kernel.org, rostedt@goodmis.org, tglx@linutronix.de, x86@kernel.org, linux-efi@vger.kernel.org, akpm@linux-foundation.org, gregkh@linuxfoundation.org, mchehab+samsung@kernel.org, shuah@kernel.org, linux-kselftest@vger.kernel.org, eparis@redhat.com, kadlec@blackhole.kfki.hu, pablo@netfilter.org, paul@paul-moore.com, coreteam@netfilter.org, linux-audit@redhat.com, netfilter-devel@vger.kernel.org, fan.du@intel.com Subject: Re: [PATCH 00/18] xfrm: Add compat layer From: David Miller In-Reply-To: <1532795215.2679.27.camel@arista.com> References: <1532703111.2679.20.camel@arista.com> <1532795215.2679.27.camel@arista.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 28 Jul 2018 14:18:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Safonov Date: Sat, 28 Jul 2018 17:26:55 +0100 > Well, I think, I'll rework my patches set according to critics and > separate compat xfrm layer. I've already a selftest to check that 32/64 > bit xfrm works - so the most time-taking part is done. The way you've done the compat structures using __packed is only going to work on x86, just FYI. The "32-bit alignment for 64-bit objects" thing x86 has is very much not universal amongst ABIs having 32-bit and 64-bit variants.