Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2485676imm; Sat, 28 Jul 2018 19:09:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdYtNIdn9nhiL1BMn6AdGrC9JaX1+NHohILTIHOSi02aTsxxnFoLgcy1ZuuVRirV8EFnmB/ X-Received: by 2002:a65:6211:: with SMTP id d17-v6mr11660662pgv.450.1532830155937; Sat, 28 Jul 2018 19:09:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532830155; cv=none; d=google.com; s=arc-20160816; b=oC7KE8UwR7+ly8XcbyellGvzfclbIzQ4f4LGT0//cODiQkFliXig3IqmyAGuVfU6a+ 1ziWwMiYzk6nrYMfaZR/y7vXU8dpZYY/xJnh7s/foAyLIQXOT+e5OBIbzsPBILl4HECz uptiX1lQRDD9TTqPL+PgHW9AjcM3VIbsGtLjY4v8RHm7Fx0rX3x+Vd48qIJg1+G1a3US K2VYEK1wxKOBWQVjETFj/GBQtS8uRWiF/t1dYDPnFQ0mulXr4P3TKCc3mDznCGfh9NrZ MyGCMY/VtizEwl444s2ocmv1797FXG/tMF487DPJX3VC4Ekx5MFOF+xqER7nGmZpmkSL dTcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Qrd521hagHAN9QYHTc+T56/v1SjbQL6EYfVKndQ7mzI=; b=zmC6hLEH746ZQE5DZMQvg5nUZt/32Li+LTFum3d8QmivkPQFXoyHbdfJUC0OSSHN6S w9DoDHMBLVXW5UbKF2Oc2v5WeQVbCqViJ+X/Pc5deTpiVvdkShn54nIOhByCFv8VbH8Y VvtTsJ9Q4j/wvNIRTxT5C86HYZAYm2f0Gkma4rE1kyADmK7fDk1apIgI4V0Krp50f+Xn t3h2vdbbGl2zcu9X3GXVnyc3c6k5tZN3PBG+6WRDFwHPeeT2qsDrFxHx4+7ovjHQoECF ZtxB6CKG/ILousK/yhOwEW+ORWaBaCoYe626i9sLkV0eYNP0NSU+jYbx9zmSOjnZ2hYT cMKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a90-v6si7015171plc.285.2018.07.28.19.09.01; Sat, 28 Jul 2018 19:09:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731775AbeG2Dgt (ORCPT + 99 others); Sat, 28 Jul 2018 23:36:49 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59862 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731506AbeG2Dgt (ORCPT ); Sat, 28 Jul 2018 23:36:49 -0400 Received: from localhost (unknown [172.56.41.34]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D691D13AED0A0; Sat, 28 Jul 2018 19:08:10 -0700 (PDT) Date: Sat, 28 Jul 2018 19:08:09 -0700 (PDT) Message-Id: <20180728.190809.1376213313357548269.davem@davemloft.net> To: andrew@lunn.ch Cc: vasilyev@ispras.ru, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, jonmason@broadcom.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair From: David Miller In-Reply-To: <20180727161707.GP10686@lunn.ch> References: <20180727155747.24978-1-vasilyev@ispras.ru> <20180727161707.GP10686@lunn.ch> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 28 Jul 2018 19:08:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Lunn Date: Fri, 27 Jul 2018 18:17:07 +0200 > On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote: >> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer >> in device, whereas mdio_mux_iproc_remove() restores md pointer by >> dev_get_platdata(&pdev->dev). This leads to wrong resources release. >> >> The patch replaces getter to platform_get_drvdata. >> >> Signed-off-by: Anton Vasilyev > > Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs") > Reviewed-by: Andrew Lunn Applied and queued up for -stable, thanks.