Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2515436imm; Sat, 28 Jul 2018 20:01:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeZWOfJrQ94tEmi8drPo5OZS5l9dcW67ATNmhV1FIregk8WIn++ZnPChK/jNGAbG/g3pDY5 X-Received: by 2002:a63:6604:: with SMTP id a4-v6mr11286034pgc.404.1532833279461; Sat, 28 Jul 2018 20:01:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532833279; cv=none; d=google.com; s=arc-20160816; b=RL3SeO5godT8h8w8rkZOJMaxEEJljdnQBDyBkcbwNOxTDTr22kn8k/iEA6QhQxzOxc nyj0lOBikD7tbqVAjifZFLO95XqVVt2dX+Atmd4sGd15ENNYbgSYhGI9J1UynavdRXhV m6hP/xwDIKD+NdR5vydoDSlqVox4xR7uEmuaNo3LrO/vAUxABNw2yDMxzb20tSIMfA1Q nvz6W6lzeyl59yyh8Xurh2x6cxB6Uick2Ilm6wkCKQcO3Ye/YEnWP9I7P7cFj+U9O3kx qWku+V4iQvzTmdNKOVEX0CIpyMHXTLTcrEPqK1/LFMIj9KNUR02hZpklmbiltOu3QRmc vmww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=S10s21Yul33D3iHRcEy5Z9y6cznqX5z2Skj9eVch6B8=; b=LzKelvJlFjMrUG539EfuyIdk2Jo8hS/4TXKZuJCOCx6QNHRQtqQbTiBgRaOxq263bq DlRlRbiUKUFPf1MDRZbZs9ZP0ThOub6wwqhzuD1FntGGlaS2dIjmkXE6v44nt4HHeLfB aZuvaTZ71HKn8as03h4A8P4UvrCwt/FnolZv5FFHEbti+BSC3jZI2ofrYjphnCm2Bl+d A1fJsMbGa1/scbXFg1UbzYSRF0yzp6QLs5NTIfECnWuRSV+mtLe/8qlHPMew47aRQD2w NPVcJDLU7Atfp8E9HiWKxkveiN2qcVtq/2V/AxGAcco7ruYm0RCYVL1F03AZPHJwcV2S PLRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=orqF3zE1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8-v6si1723494pgo.2.2018.07.28.20.01.05; Sat, 28 Jul 2018 20:01:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=orqF3zE1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbeG2E2Z (ORCPT + 99 others); Sun, 29 Jul 2018 00:28:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:34560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbeG2E2Z (ORCPT ); Sun, 29 Jul 2018 00:28:25 -0400 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C5572089A for ; Sun, 29 Jul 2018 02:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1532833179; bh=S10s21Yul33D3iHRcEy5Z9y6cznqX5z2Skj9eVch6B8=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=orqF3zE1W/fQjb/bJXru2Kckz9oC8M4PFe74nuvPsI38btUPkObKB0dwaUW5Xefj+ 4XanXmmXrUjhoPB0bQqeWrZyU6x1VLAIpRnBiMIH4uDJz/Ngwe3l4uaf4FFkqDcIEK vJ+CrwdGzRVzKrOTcEUxXj+s/t8RZCEjdCpjLSxk= Received: by mail-wr1-f43.google.com with SMTP id v14-v6so8958525wro.5 for ; Sat, 28 Jul 2018 19:59:39 -0700 (PDT) X-Gm-Message-State: AOUpUlElneeRZIDoai7Qb9feYelBhmz1mg8SQqHRqTmMaprd4oL2x1ki zeoXdf5akuobMiM/77DQmI5/R3jfB5k/GZXdaHXaKQ== X-Received: by 2002:adf:db11:: with SMTP id s17-v6mr6001657wri.221.1532833177668; Sat, 28 Jul 2018 19:59:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:548:0:0:0:0:0 with HTTP; Sat, 28 Jul 2018 19:59:17 -0700 (PDT) In-Reply-To: <20180728215357.3249-3-riel@surriel.com> References: <20180728215357.3249-1-riel@surriel.com> <20180728215357.3249-3-riel@surriel.com> From: Andy Lutomirski Date: Sat, 28 Jul 2018 19:59:17 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 02/10] smp: use __cpumask_set_cpu in on_each_cpu_cond To: Rik van Riel Cc: LKML , kernel-team , Peter Zijlstra , Andrew Lutomirski , X86 ML , Vitaly Kuznetsov , Ingo Molnar , Mike Galbraith , Dave Hansen , will.daecon@arm.com, Catalin Marinas , Benjamin Herrenschmidt Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 28, 2018 at 2:53 PM, Rik van Riel wrote: > The code in on_each_cpu_cond sets CPUs in a locally allocated bitmask, > which should never be used by other CPUs simultaneously. There is no > need to use locked memory accesses to set the bits in this bitmap. > > Switch to __cpumask_set_cpu. Reviewed-by: Andy Lutomirski