Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3088712imm; Sun, 29 Jul 2018 10:02:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeH1D9AVao3JI026YTnIZQSUivAvrSqzrQGBLVXpnYeejWQyo89IYVLJHIPKw3FPQzu7Q5k X-Received: by 2002:a63:eb0e:: with SMTP id t14-v6mr13248709pgh.198.1532883733543; Sun, 29 Jul 2018 10:02:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532883733; cv=none; d=google.com; s=arc-20160816; b=TfyuQO7sckcqK7V0RcUr64OHocYO8R3dBRbDZg5GUywFUnLcE/LyE5eo0LMjF3OCDo c5MthN8YoUndgZNTuAjpZTKvr8ZGlQAhxEWqjvf0Rmk97Ms6gjIMHl32+GGsxqy0vXGK XH56ifelvbAc9nfqKEmRPEnPMLKoxU8T3ZxiQ6ZVcAaH/2qNGdxfkiSt9G6ki9kNGMP5 DjbPIlfdCTPGuS3V7SW+ksLvW7zpO1Fhrke++Xz3rXBA5o3Ux1qzlXq3wDtyDTn2/FZ2 Zmg1ASpR//7SHMDS+oMIKClI7Kv87cDgrTkSs4gtjYZhRJ9bxeBbgbI3+tfZx+GBLwh/ GsFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=MaM9ljMSNey1SbuFnarecIcefEdwYGq2NoEgqvZ6X10=; b=xn/LX3k34tH048+ooIFOcjNYM+UbXEPDs2pSVzcbruNQnoBhFShnBZFL1sIgIokB/s z5ubxtV1usSBqztAqChM+7wLV6u2OvLyD1BXNwIXoysM7994oF082O9oYt8n50cxzIx7 OWEnByYVGTLvcmuOHpbGyjSoeoATQy+MnDyfBaRku4OgUezMGgHHrVOPPWp6kLdC4KvP qMekoZ4KRs6mmyDsvTov6Khpn4n9PobI5OScVL10kyjiIVrj4GQYbL/Xdl3rYiWeAWSL hlYxMH4KJz9mTKEcircBi8qg1K4CWvOYtd4XM3MIBtS3feBL6zmx1t6Q9abr2fqD/lJY YKyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TV4ebTyA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f40-v6si8292498plb.504.2018.07.29.10.01.58; Sun, 29 Jul 2018 10:02:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TV4ebTyA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbeG2ScP (ORCPT + 99 others); Sun, 29 Jul 2018 14:32:15 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:42414 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbeG2ScP (ORCPT ); Sun, 29 Jul 2018 14:32:15 -0400 Received: by mail-oi0-f67.google.com with SMTP id n84-v6so17220559oib.9 for ; Sun, 29 Jul 2018 10:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MaM9ljMSNey1SbuFnarecIcefEdwYGq2NoEgqvZ6X10=; b=TV4ebTyA1vSpElfkGEl1KY/4kAvQ0/jG3aqd+ogsMOlqWIdHxPBPoeHXzGna2RqDnq XLDM2olMviFdFsoW6cS3fQ/LcZtzRfpMhctqQWLO6BkPeklc8+1XxLayVwMv2ERO/C0J DlijAig3uycyCROaexfD1SN9VhRqDugtyNhdDgZy70Q84kLdxMrTfauNxUZQLTNUcVgj zbqFfvFtKNkvaD2e1d8vSjb5B1wCmUdErfTdolcR1TJHdfpf2bOYFfFQUwB0dIbW0CGB UzZYV502E1IVgdAh2bksYjUtQk+RPr0K8ORYPy+DQyWQL9tXoTcr1I4wxIx3lYTHhkn6 b+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MaM9ljMSNey1SbuFnarecIcefEdwYGq2NoEgqvZ6X10=; b=p+OcerbDOQItaGete/5beQwEDXegORQeyZqiiqjRSXh2ESkG2fCGO5AgO9cuTM5qpX BkWBrQC4+W1sA9tF7BHd22GAYs4xH/Zra5r7dcD5JuvI1RB6H/nu1m6m1emrkHRlbyVt DyRxciWU4Jcjlv18kVmT3DeKan8+xN1l7Yfd9+S+Txu8e6+u7HJOBlGCTJMs/nbVNqv/ PlWuqdAtpl7BCfJxwg4jg315lgX1F3PVQfKcvoqkAZcue+1j8rlSO+zXP5YM6QpUnLY/ 0oygoZ8PXP4JBo5aPZwz9vP3U1RAyhcQOz/f/HOOXy0n1bU0/JITgLBxsbZPt5L0jZp4 krfw== X-Gm-Message-State: AOUpUlFTnNJZscPLkxi4rnYhTz4VssOmmsra/W8YcjVpC3j29legWBMr 8IG1owXo+d+BQNN3ElPWkZGsny+irYFYVXsEjt8= X-Received: by 2002:aca:cd84:: with SMTP id d126-v6mr15816532oig.325.1532883670155; Sun, 29 Jul 2018 10:01:10 -0700 (PDT) MIME-Version: 1.0 References: <20180729144358.3442-1-tsotsos@gmail.com> In-Reply-To: <20180729144358.3442-1-tsotsos@gmail.com> From: Georgios Tsotsos Date: Sun, 29 Jul 2018 20:00:58 +0300 Message-ID: Subject: Re: [PATCH] Staging: octeon: Fixing coding style for minor notices. To: Greg Kroah-Hartman Cc: John Smith , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000a4491d0572264a95" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000a4491d0572264a95 Content-Type: text/plain; charset="UTF-8" Please ignore this patch i will send series which will fix more coding style and other issues On Sun, 29 Jul 2018 at 17:44, Georgios Tsotsos wrote: > Fixing coding style for a few lines that were reported to check from > checkpatch.pl in minor cases for alignment and ending with parenthesis. > > Signed-off-by: Georgios Tsotsos > --- > drivers/staging/octeon/ethernet.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet.c > b/drivers/staging/octeon/ethernet.c > index 9b15c9ed844b..1e258deecacc 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -141,8 +141,8 @@ static void cvm_oct_periodic_worker(struct work_struct > *work) > if (priv->poll) > priv->poll(cvm_oct_device[priv->port]); > > - cvm_oct_device[priv->port]->netdev_ops->ndo_get_stats( > - > cvm_oct_device[priv->port]); > + cvm_oct_device[priv->port]->netdev_ops > + > ->ndo_get_stats(cvm_oct_device[priv->port]); > > if (!atomic_read(&cvm_oct_poll_queue_stopping)) > schedule_delayed_work(&priv->port_periodic_work, HZ); > @@ -621,8 +621,8 @@ static const struct net_device_ops > cvm_oct_pow_netdev_ops = { > #endif > }; > > -static struct device_node *cvm_oct_of_get_child( > - const struct device_node *parent, int > reg_val) > +static struct device_node *cvm_oct_of_get_child(const struct device_node > *parent > + , int reg_val) > { > struct device_node *node = NULL; > int size; > @@ -818,7 +818,7 @@ static int cvm_oct_probe(struct platform_device *pdev) > priv = netdev_priv(dev); > priv->netdev = dev; > priv->of_node = cvm_oct_node_for_port(pip, > interface, > - > port_index); > + port_index); > > INIT_DELAYED_WORK(&priv->port_periodic_work, > cvm_oct_periodic_worker); > -- > 2.16.4 > > -- Best regards! *Georgios Tsotsos * *Greece-Evia-Chalkida* *tsotsos@linux.com * *skype:* *tsotsos* ------------------------------------ Georgios Tsotsos *Greece - Evia - Chalkida* tsotsos[at]linux.com skype: tsotsos --000000000000a4491d0572264a95 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please ignore this patch i will send series which will fix= more coding style and other issues

On Sun, 29 Jul 2018 at 17:44, Georgios Tsotsos <tsotsos@gmail.com> wrote:
Fixing coding style for a few lines that were repo= rted to check from
check= patch.pl in minor cases for alignment and ending with parenthesis.

Signed-off-by: Georgios Tsotsos <tsotsos@gmail.com>
---
=C2=A0drivers/staging/octeon/ethernet.c | 10 +++++-----
=C2=A01 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c
index 9b15c9ed844b..1e258deecacc 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -141,8 +141,8 @@ static void cvm_oct_periodic_worker(struct work_struct = *work)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (priv->poll)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 priv->poll(cvm_o= ct_device[priv->port]);

-=C2=A0 =C2=A0 =C2=A0 =C2=A0cvm_oct_device[priv->port]->netdev_ops-&g= t;ndo_get_stats(
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0cvm_oct_device[priv->port]);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cvm_oct_device[priv->port]->netdev_ops +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0->ndo_get_stats(cvm_oct_device[pri= v->port]);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!atomic_read(&cvm_oct_poll_queue_stoppi= ng))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 schedule_delayed_wo= rk(&priv->port_periodic_work, HZ);
@@ -621,8 +621,8 @@ static const struct net_device_ops cvm_oct_pow_netdev_o= ps =3D {
=C2=A0#endif
=C2=A0};

-static struct device_node *cvm_oct_of_get_child(
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const struct device_node *parent, int= reg_val)
+static struct device_node *cvm_oct_of_get_child(const struct device_node *= parent
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0, int reg_val)
=C2=A0{
=C2=A0 =C2=A0 =C2=A0 =C2=A0 struct device_node *node =3D NULL;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 int size;
@@ -818,7 +818,7 @@ static int cvm_oct_probe(struct platform_device *pdev)<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 priv =3D netdev_priv(dev);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 priv->netdev =3D dev;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 priv->of_node =3D cvm_oct_node_for_port(pip, interface,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0port_index);
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0port_i= ndex);

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 INIT_DELAYED_WORK(&priv->port_periodic_work,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 c= vm_oct_periodic_worker);
--
2.16.4



--
Best regards!
Greece-Evia-Chalkida
tsotsos@li= nux.com
skype:=C2=A0tsotsos
------------= ------------------------
Georgios T= sotsos
*Greece - Evia - Chalkida*
=
tsotsos[at]linux.com
skype:=C2= =A0tsotsos
--000000000000a4491d0572264a95--