Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3220950imm; Sun, 29 Jul 2018 13:12:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpchaW/LYw1juMjpT98GLbcEVx2Mmw62fcOL5yU8VutzdZOinFP+CQazkG1EdgmhQfscaXpT X-Received: by 2002:a62:998:: with SMTP id 24-v6mr14818802pfj.99.1532895173215; Sun, 29 Jul 2018 13:12:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532895173; cv=none; d=google.com; s=arc-20160816; b=Srmu7DXxVBlajhltDi30MWtjT1wgydPgNBAhXNfC2qQMgAGdrB1EtGRPMYMvnj7iNa ukhTqTcCaqJwyS9PbiIthOusXMS2ahq/lpvS0rgcWNugrJdyhYUx+HLNptHalwu/fqz7 VwdKiCMbjaal6hyGPHxyNsyo5M/WTNQEs+PEDjZ1xyqjRgI+fFbrXlsXHx7W7KKYNGpE 7HhxV04O6V5oFo+jmwfUoJ/rN4lL6hzonEW9SAfGkvBzXQM+dVwrGVlYD+2zwyB2TooQ HkmDVooufkWqIeX5ASzMRYOCOuxvbxFwdSNZ9/DGnCLk0Hsjje7miUMSe7BCzq6sUg/F waow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Z5qcUh8rBFQKNr+Z5RMiuJvwq13O8zDj2OFQY+BqrbA=; b=z1vyZzl+ozSeBSUzvM1FRy11dN9ttc8Cz+oFAqAqqVm0jaNlDcUI9FW7KEDSG3AM37 usdX2Ov8aDBRB8i8Xsoyk4QzShbxK8m43imNCQmWaWzCw9s50F1kihEwfMERk0qHi/7d 2Q8wbewpow1y4kGRg47Fzah4h4rX/xqf2pFlw2S6NFwtaHm9R7PcbXXLkgLdGGeizTKw aebBAjmjyxBHvvvQOgshc59Nh7DAWNSLU5CsHJeYCaKBMH+CSt9/XWhxXo6cjHHv8vLQ 0SC5MfEr5idydp8kwWsxWJ1hG9n/WMQhYbgf+/kM/Ko1A5kzUizPI+OcZIrHjwSKfg/R nnWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p5-v6si8214644pgl.516.2018.07.29.13.12.39; Sun, 29 Jul 2018 13:12:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728735AbeG2Vnb (ORCPT + 99 others); Sun, 29 Jul 2018 17:43:31 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44244 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726785AbeG2Vna (ORCPT ); Sun, 29 Jul 2018 17:43:30 -0400 Received: from localhost (c-73-37-107-99.hsd1.or.comcast.net [73.37.107.99]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D5C1B13E3B35C; Sun, 29 Jul 2018 13:11:50 -0700 (PDT) Date: Sun, 29 Jul 2018 13:11:50 -0700 (PDT) Message-Id: <20180729.131150.2292075046399424568.davem@davemloft.net> To: tyhicks@canonical.com Cc: gregkh@linuxfoundation.org, hkallweit1@gmail.com, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] sysfs: Fix regression when adding a file to an existing group From: David Miller In-Reply-To: <1532727207-10912-1-git-send-email-tyhicks@canonical.com> References: <1532727207-10912-1-git-send-email-tyhicks@canonical.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 29 Jul 2018 13:11:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tyler Hicks Date: Fri, 27 Jul 2018 21:33:27 +0000 > Commit 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging > to arbitrary users") incorrectly changed the argument passed as the > parent parameter when calling sysfs_add_file_mode_ns(). This caused some > sysfs attribute files to not be added correctly to certain groups. > > Fixes: 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users") > Signed-off-by: Tyler Hicks > Reported-by: Heiner Kallweit > --- > > Note, this was a regression exclusively in linux-next and never made it to > Linus' tree. There's no need to queue it up for linux-stable. Applied, thank you.