Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3288184imm; Sun, 29 Jul 2018 15:06:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfv5ANGx/2Y5KwcNF4P6pZaEPTYjwq9nD3v9ysjEG0xf2LSmgiwqMt8HRG4mwqWKqqK7ShB X-Received: by 2002:a17:902:4201:: with SMTP id g1-v6mr6318143pld.203.1532902015644; Sun, 29 Jul 2018 15:06:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532902015; cv=none; d=google.com; s=arc-20160816; b=LxwzRq7W7ACslpLsVU2N1gGd3MdaeqqdVA5rJfZM1p2r7N2ODVXQiEPbbypr2pHUDf NGhllJULmmsrvm7ptgtJ8kgb61kK5x9NhAHRFkDRKyMJ6cY+cROP1ktIcl0K3JDQ+pFV EsccyxsBOHQAMAGaL3HfCdbwRLE197f9F2+Vi4B06XhUAeAwwrCYMy6ONsrXTjXg2YPv DxijZLmBObl6cUSvEOs57GiqCVONUnQEKaeYE6HFScQ3Qvqup0Moeb4shPZSNQ67ApUN 5EUmwIe0nNMNts7Qs2kpc+TEMdjomEHkSoYm2NASlXH8RbBe/LSwcZjByHMwEmeRgDIs S4gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=JNQHdYTFw2qT1MNuD+UBcmSrRFtuzQsQn6bcL7V5dUo=; b=XGv/fUrbtmS0lqL38XHo24ec0jckNt9iT+jcZQDnrLMBFVmEVnq4pzIGGwpzxPg/gr OXWvblC9RQMh7N1x8/C6acdcZZBoEEANTWMpeq09dvQaYl2ezQUQFWll0rjg4HAtYxGK LVATI3XEz4neN8r0zbrBv+cvMvgw/6YwP2s6STlVvKY0/SK8NRdxOXMIyMHSKQOyEyST 1rdkfwAG6ttL9qRnWnCp4tLYy1Hmszj9N+89h2ZMSaFK7oGBcZOO6rUJ+60n3df0o6AN 7eUgQdKumMZGVrcv4iDzKwA01sTgf3pwtuVs5Wu0Q4hQPdCPlOX1O1mmysAGQ5c+KHWI CYKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x18-v6si8366950pll.88.2018.07.29.15.06.41; Sun, 29 Jul 2018 15:06:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732164AbeG2XhB (ORCPT + 99 others); Sun, 29 Jul 2018 19:37:01 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:51650 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728713AbeG2Xg5 (ORCPT ); Sun, 29 Jul 2018 19:36:57 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fjto7-0003Wt-M5; Sun, 29 Jul 2018 22:04:55 +0000 From: Al Viro To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Miklos Szeredi Subject: [PATCH 16/16] jfs: don't bother with make_bad_inode() in ialloc() Date: Sun, 29 Jul 2018 23:04:53 +0100 Message-Id: <20180729220453.13431-16-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20180729220453.13431-1-viro@ZenIV.linux.org.uk> References: <20180729220317.GB30522@ZenIV.linux.org.uk> <20180729220453.13431-1-viro@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro We hit that when inumber allocation has failed. In that case the in-core inode is not hashed and since its ->i_nlink is 1 the only place where jfs checks is_bad_inode() won't be reached. Signed-off-by: Al Viro --- fs/jfs/jfs_inode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/jfs/jfs_inode.c b/fs/jfs/jfs_inode.c index 96732c24b054..4572b7cf183d 100644 --- a/fs/jfs/jfs_inode.c +++ b/fs/jfs/jfs_inode.c @@ -69,8 +69,6 @@ struct inode *ialloc(struct inode *parent, umode_t mode) rc = diAlloc(parent, S_ISDIR(mode), inode); if (rc) { jfs_warn("ialloc: diAlloc returned %d!", rc); - if (rc == -EIO) - make_bad_inode(inode); goto fail_put; } -- 2.11.0