Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3348485imm; Sun, 29 Jul 2018 16:47:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfZ0H2jvDFwy5Swh1f87gzLqeWVLOh9HX3OuGKmjYFBvtIw3HNFw4vB3I9aaf4CbzykiEcM X-Received: by 2002:a63:c114:: with SMTP id w20-v6mr14119680pgf.234.1532908052000; Sun, 29 Jul 2018 16:47:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532908051; cv=none; d=google.com; s=arc-20160816; b=g8l1Epr1QJTbfh+Dlp98RUxzQJnozlMmi8k/cOmGkH7c7w0mKMXrGqt5xRbUjtk83g lU7leZcL1+UpISQqV4oBp7+jVe9ZjSKvCMu7B74eu2CbshNu4DcPZv//UwPGgp9qBgsQ BSiFUlRA9yaXyoNBnsq6S+BO/9nhISa9WZ0pDru/VBQhv0OKm0RgUjA+GOX9XHOFJEBa hXdNJCvalGXi4HPcp/G1zthccqN6zmdY0lqtCQp+nMMY3DWNQiwhv/axtHqLJXvvujYv WVeXBUbCw82YRra61nJOLWcT9CUqjrImjwuPz5WZJNoeJaM1+I+GUKq1qPWAuI6Tt8FY y3TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=r7RC4Vj7QqvT3awHXNjKpq1wj3R0ios9S4af+iLQ/i8=; b=nM+hipdxjry6N7AM2mlo/FqyUA2kAhyNQykDYv9jfTUPfMLLWx7kf2rUEDlHxBr4ip Iu45cuO8RPrHDGrPbhsJb/D9jXv8EfctgMTA0TJFWhMTIRimqEqczEW/CyELna8kV0CW EfLlDHeWoESuEd3hGdJr39GcKyKBQgag8nzalxwVqKtbeRzF3lrS/kEjTGdkHP8J6c9D JI02/+U99Z8ydfBa7ay1KeDpEnzZQeqlkhIUGhtvX6M3KdXA54fsYwIMOAawMy8cP+XF laeTQEUSWsBAr4s5L2MaLepOhC9h/eIwlecpSByDpmZROViBSZuLleKE3FIkEEPVg7/5 i45w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=k7bvI1Lj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5-v6si1983207plh.18.2018.07.29.16.47.17; Sun, 29 Jul 2018 16:47:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=k7bvI1Lj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730613AbeG3ABs (ORCPT + 99 others); Sun, 29 Jul 2018 20:01:48 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45393 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729283AbeG3ABs (ORCPT ); Sun, 29 Jul 2018 20:01:48 -0400 Received: by mail-wr1-f67.google.com with SMTP id f12-v6so802247wrv.12 for ; Sun, 29 Jul 2018 15:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r7RC4Vj7QqvT3awHXNjKpq1wj3R0ios9S4af+iLQ/i8=; b=k7bvI1Ljoa+rybMrz5Dwez7Tr7LC07r457WtkpDOC5DlXCzdx4Tz0T516wBt2J4z45 yZwfEr0mHZfxLumFB9WOE9SOIaTAOgHtik9nQWXHpGL8Xp6ZcXGoqY/n/GZXNSmE29Qg zhsfNcln2q7utubsuimT/37EQNXpe5hqoDSOOprXsnu88OagEneh1/0RmdseWHpWajcM gZ8/aHlyHde6DheCMxzo1tt84ykfTqZEqoaLqKlGHGhc4atTlkU84ZcLA9eHhBCqAizm gIM4f7FH1nHJJFtvumZclkYL0pJoEYXbSs4QW4SEljcAwUp6xv+04r/p8JNPSTls0m1Z lowg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r7RC4Vj7QqvT3awHXNjKpq1wj3R0ios9S4af+iLQ/i8=; b=m9mGds6Vw6kuzwFl4LYMtV/jcMsqxo9NIMTw2g9yfYXEW5ipo8nrGEoQNyq4auLyKM HSpJWH6sLMP/4WYseDyYnty8x0KCZqeiovbMsqzq19BIoTeSVz5xc8SxsFSWhe8tbU8R l4SWiyQZbMTa3bGadLv6Er2a5O9MTRblUbLvweHpuTrZk/Z63CmY6D0w2iYz+1ar3wJQ 4YrQyOcQdIL8h0xpbQW6eYeTA+bDR+Zeha7SE1Bhay5FyIQWsYcwfI5xSl//M3Z/bO7p wa4BrYKEvp9L/QszfD3nSCs4lT3xmM26fLoabWSxdX7YHeUSNEXZm8NyOXnqWQd6T6ym SKNA== X-Gm-Message-State: AOUpUlGdHTGIWihutJd8lbzkB/t9Pb/8qVg5tBOLtsN1hQ6aKZTRcRZw KFF186SoMsh0MRFZaLAiqAC1fnWp X-Received: by 2002:adf:9f13:: with SMTP id l19-v6mr14800137wrf.206.1532903381617; Sun, 29 Jul 2018 15:29:41 -0700 (PDT) Received: from we.local (ppp-2-87-92-87.home.otenet.gr. [2.87.92.87]) by smtp.gmail.com with ESMTPSA id a12-v6sm9267643wru.61.2018.07.29.15.29.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 29 Jul 2018 15:29:40 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by we.local (Postfix) with ESMTP id 9186F6407C0; Mon, 30 Jul 2018 01:29:39 +0300 (EEST) X-Virus-Scanned: amavisd-new at local Received: from we.local ([127.0.0.1]) by localhost (we.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DnEgbgjrwuMf; Mon, 30 Jul 2018 01:29:39 +0300 (EEST) Received: by we.local (Postfix, from userid 1000) id 28D806408DF; Mon, 30 Jul 2018 01:29:39 +0300 (EEST) From: Georgios Tsotsos To: Greg Kroah-Hartman Cc: Georgios Tsotsos , Aaro Koskinen , James Hogan , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v5] Staging: octeon-usb: Using defined error codes and applying coding style. Date: Mon, 30 Jul 2018 01:29:36 +0300 Message-Id: <20180729222936.27608-1-tsotsos@gmail.com> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180729202108.GB14390@darkstar.musicnaut.iki.fi> References: <20180729202108.GB14390@darkstar.musicnaut.iki.fi> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replaced -1 with defined error code EINVAL Signed-off-by: Georgios Tsotsos --- v2: Apply coding style to function cvmx_usb_poll_channel v3: Break down function cvmx_usb_poll_channel v4: Return defined error code and applying coding style for function calls v5: Fixing wrong patch applied before with typo on dev_err and applying coding style as suggested on v3 drivers/staging/octeon-usb/octeon-hcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index c9fbff93bed4..dd73fd48e12e 100644 --- a/drivers/staging/octeon-usb/octeon-hcd.c +++ b/drivers/staging/octeon-usb/octeon-hcd.c @@ -2587,10 +2587,10 @@ static void cvmx_usb_transfer_isoc(struct octeon_hcd *usb, } } else { pipe->next_tx_frame += pipe->interval; - cvmx_usb_complete(usb, pipe, transaction, CVMX_USB_STATUS_OK); } } + /** * Handles channels halt in non DMA mode * @hcchar_chena: @@ -2629,7 +2629,7 @@ static int cvmx_usb_dma_halt(u32 hcchar_chena, u32 hcint_xfercompl, * Channel halt isn't needed. */ } else { - dev_ err(dev, "USB%d: Channel %d interrupt without halt\n", + dev_err(dev, "USB%d: Channel %d interrupt without halt\n", usb->index, channel); return -EINVAL; } -- 2.16.4