Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3750235imm; Mon, 30 Jul 2018 02:49:14 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcFu8njjbpKYrchcjU6xC4bLRY52W2uiOknYrc6ADtHgMZX/ENDjAiRqQSXsTxOyYrjOrsM X-Received: by 2002:a63:5b0d:: with SMTP id p13-v6mr15960266pgb.202.1532944154487; Mon, 30 Jul 2018 02:49:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532944154; cv=none; d=google.com; s=arc-20160816; b=zm47voWIfUVyB9F0q3EZd3LXIKfqnlgbeX0K8AAV8LOKTtnmenOuOinNz2IxswIc4p G8GzTyHpfUyDlDhJXxnSF92S9Ba/GVj+HxdiM9A0eDlr63lvNBWh4hrMOdBVLkUQlIFN vTEKj4xf9ao4PC7R+XFUotOSumEkWF0MaMeK5JR3M59B9gRbHE3eLCgF6Rn4uEQB+eF5 hWQRfqe5giLvjXizFOyv5ZpnxvgosIjhOUoqLT32d5Rr92vTAb8S+/cqKrN3mQLJ4h1Q k1phMVX6lY+BVbwwsGwWnHZg9cm6QTc9pd5O5xU+gMwX1JpAt5QHip04ulAZwn/BvwiI GzAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=cFnCKB4s+8rDfc4BBWJjcC+byTq1tl94iB/4vhJVrqE=; b=tAy9QGhhzsY8oltBLk/myflFUwL5NRnYwNPyj9EunTRMJUY0XArkFaDWZ4HztggSJK x85Q348NvMUMRwTNtUJBAiof0HY0xU2cu+moE+X+wgPJcDDuPmnBX56e7kRL64BA9XFF 5/v0bP4HTBeKW4PXHTYi3V32/WJL/dXmzSdxwtln+SfIptTb3sv5EXFHWIwOvDQAu92K seY3vjqzVYDI9DPHq6gefHjO7Umg9I92oAw9Nko4sSa+E6mF6oOpVwXUL+hVLpUAMx80 BkP2Q4x0RD9PEjHAgZ9zgnwOuO25Sh9wTfX8HcrzT9M+HI80qtwJb4SkvQWl/68t5q7V TAFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si10945736pfb.262.2018.07.30.02.49.00; Mon, 30 Jul 2018 02:49:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbeG3LVV (ORCPT + 99 others); Mon, 30 Jul 2018 07:21:21 -0400 Received: from mail.us.es ([193.147.175.20]:46730 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727092AbeG3LVV (ORCPT ); Mon, 30 Jul 2018 07:21:21 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 54D58C510F for ; Mon, 30 Jul 2018 11:45:03 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 06DBEDA4D9 for ; Mon, 30 Jul 2018 11:45:02 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id D937CDA4D1; Mon, 30 Jul 2018 11:45:01 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7D17FDA8FD; Mon, 30 Jul 2018 11:44:58 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Mon, 30 Jul 2018 11:44:54 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.241.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 316ED426CC51; Mon, 30 Jul 2018 11:44:58 +0200 (CEST) Date: Mon, 30 Jul 2018 11:47:02 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: YueHaibing Cc: kadlec@blackhole.kfki.hu, fw@strlen.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH] netfilter: use PTR_ERR_OR_ZERO() Message-ID: <20180730094702.oiau2jolf3ps4cjb@salvia> References: <20180719132009.19568-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180719132009.19568-1-yuehaibing@huawei.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 19, 2018 at 09:20:09PM +0800, YueHaibing wrote: > Fix ptr_ret.cocci warnings: > > net/netfilter/xt_connlimit.c:96:1-3: WARNING: PTR_ERR_OR_ZERO can be used > net/netfilter/nft_numgen.c:240:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci Applied, thanks.