Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1530853931-12061-1-git-send-email-yamada.masahiro@socionext.com> <CAK7LNAS_XrYKuv7OgTEt9RSGLbCe-XumV4QNKUtS2YT9HWMk3Q@mail.gmail.com>
In-Reply-To: <CAK7LNAS_XrYKuv7OgTEt9RSGLbCe-XumV4QNKUtS2YT9HWMk3Q@mail.gmail.com>
From:   Nayan Deshmukh <nayan26deshmukh@gmail.com>
Date:   Mon, 30 Jul 2018 18:19:36 +0530
Message-ID: <CAFd4ddxsBsg0gKwW3iCidFRSC+p0VaQFQb=GyAZrgoVVGnDscg@mail.gmail.com>
Subject: Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag
To:     yamada.masahiro@socionext.com
Cc:     airlied@linux.ie,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: multipart/alternative; boundary="0000000000009e36ec057236e7ef"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--0000000000009e36ec057236e7ef
Content-Type: text/plain; charset="UTF-8"

On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada <
yamada.masahiro@socionext.com> wrote:

> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com
> >:
> > I refactored the include directives under include/drm/ some time ago.
> > This flag is unneeded.
> >
>
A minor nit-pick in the commit message, something like "With the refactored
include directives under include/drm, this flag is uneeded." might be
better.

> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
With or without that the patch is Acked-by: Nayan Deshmukh <
nayan26deshmukh@gmail.com>

Regards,
Nayan Deshmukh

>
> Ping?
>
>
> > ---
> >
> >  drivers/gpu/drm/scheduler/Makefile | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> >  # OTHER DEALINGS IN THE SOFTWARE.
> >  #
> >  #
> > -ccflags-y := -Iinclude/drm
> >  gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> >  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

--0000000000009e36ec057236e7ef
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br><div class=3D"gmail_quote"><div dir=3D"ltr">On Sat=
, Jul 28, 2018 at 6:54 PM Masahiro Yamada &lt;<a href=3D"mailto:yamada.masa=
hiro@socionext.com">yamada.masahiro@socionext.com</a>&gt; wrote:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex">Hi.<br>
<br>
2018-07-06 14:12 GMT+09:00 Masahiro Yamada &lt;<a href=3D"mailto:yamada.mas=
ahiro@socionext.com" target=3D"_blank">yamada.masahiro@socionext.com</a>&gt=
;:<br>
&gt; I refactored the include directives under include/drm/ some time ago.<=
br>
&gt; This flag is unneeded.<br>
&gt;<br></blockquote><div>A minor nit-pick in the commit message, something=
 like &quot;With the=20
refactored include directives under include/drm, this flag is uneeded.&quot=
;=20
might be better.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
&gt; Signed-off-by: Masahiro Yamada &lt;<a href=3D"mailto:yamada.masahiro@s=
ocionext.com" target=3D"_blank">yamada.masahiro@socionext.com</a>&gt;<br></=
blockquote><div><div>With or without that the patch is Acked-by: Nayan Desh=
mukh &lt;<a href=3D"mailto:nayan26deshmukh@gmail.com" target=3D"_blank">nay=
an26deshmukh@gmail.com</a>&gt;<br><br></div><div>Regards,<br></div><div>Nay=
an Deshmukh <br></div></div><blockquote class=3D"gmail_quote" style=3D"marg=
in:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Ping?<br>
<br>
<br>
&gt; ---<br>
&gt;<br>
&gt;=C2=A0 drivers/gpu/drm/scheduler/Makefile | 1 -<br>
&gt;=C2=A0 1 file changed, 1 deletion(-)<br>
&gt;<br>
&gt; diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/sche=
duler/Makefile<br>
&gt; index bd0377c..7665883 100644<br>
&gt; --- a/drivers/gpu/drm/scheduler/Makefile<br>
&gt; +++ b/drivers/gpu/drm/scheduler/Makefile<br>
&gt; @@ -20,7 +20,6 @@<br>
&gt;=C2=A0 # OTHER DEALINGS IN THE SOFTWARE.<br>
&gt;=C2=A0 #<br>
&gt;=C2=A0 #<br>
&gt; -ccflags-y :=3D -Iinclude/drm<br>
&gt;=C2=A0 gpu-sched-y :=3D gpu_scheduler.o sched_fence.o<br>
&gt;<br>
&gt;=C2=A0 obj-$(CONFIG_DRM_SCHED) +=3D gpu-sched.o<br>
&gt; --<br>
&gt; 2.7.4<br>
&gt;<br>
<br>
<br>
<br>
-- <br>
Best Regards<br>
Masahiro Yamada<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href=3D"mailto:dri-devel@lists.freedesktop.org" target=3D"_blank">dri-de=
vel@lists.freedesktop.org</a><br>
<a href=3D"https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel=3D=
"noreferrer" target=3D"_blank">https://lists.freedesktop.org/mailman/listin=
fo/dri-devel</a><br>
</blockquote></div></div>

--0000000000009e36ec057236e7ef--