Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4001993imm;
        Mon, 30 Jul 2018 07:06:31 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpfJhv3b/NOxe9IAz66dgmy2jXBXitNUf+Gd8QzbQFj+4fqYXQFv5/TknixOvBYbbJ/O7VQA
X-Received: by 2002:a63:920c:: with SMTP id o12-v6mr16633304pgd.141.1532959591608;
        Mon, 30 Jul 2018 07:06:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1532959591; cv=none;
        d=google.com; s=arc-20160816;
        b=k2+vGPIYDBbF9TLhSbWyfQHmQw3VZ29053+HK+V6mT6fTylEd0qWQMuCN0VRYF1QNp
         s22iaCY0owOLS2IwwBiwm9WuS9Jpu1qL1U6zuptJRw0YnjU9X19l+8OQ3ShYRcBsag3T
         lr6nCPviQrnNp9p7SGd+wy8P7eOXfCSbVu4K5eUFbI89PAD2ihyUApEVyR+qk7O7L8Qm
         7Ze+JiGsN11KE7r6E6bnkvxfGIAaxnAyvMDNS4bYNuYJYDeehsDX5MdpYmiAx3lHiCgC
         CVqm2tPcp1hcnhrcAZMdc+m0BbKPn4XSclEtYiBWeDFwGKfDQaNTbLOFSQsX6DptsUcR
         +eWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=Xm7vDrxaeeckDEp/0C4LgkigsNy8k1BkqsuusZEEfe8=;
        b=NFGfkoB8vU81htqnK3DhZ60i54lRnF1w5PusFMx/ZIUldxoeJTrE8gS6hBEiwG6mi9
         BQ3b90c3zpCaSXmQ85iVK09yGzLrITVvRRyu1JHRZFRTjGlZjb5vfZu3l3feSrsks5f9
         Vv0VJizCqJwA0q5352qFMb7IvDPDXsapXys96lS3/azum0wGiLeFHhKwUc1hpcu+WYP5
         YnJ2RDc42phvyp1sJIP56I4nCvt8YTMFEoWOgsuA5LR1ynrhyY/cHxc0qoM9lKy2gTxJ
         HhS9h9QDaNpixjT92z3WfQetNfBSjTRsRJcXsFE35q6Gdvwzxss+gu5ydbrd41TJdnnx
         vK+w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id p67-v6si11336115pfg.295.2018.07.30.07.06.16;
        Mon, 30 Jul 2018 07:06:31 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728750AbeG3Pj7 (ORCPT <rfc822;rmelvin.vger@gmail.com>
        + 99 others); Mon, 30 Jul 2018 11:39:59 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:6026 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726632AbeG3Pj7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jul 2018 11:39:59 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b5f1af70000>; Mon, 30 Jul 2018 07:04:39 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 30 Jul 2018 07:04:50 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 30 Jul 2018 07:04:50 -0700
Received: from [10.21.132.122] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 30 Jul
 2018 14:04:48 +0000
Subject: Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback
To:     Mark Brown <broonie@kernel.org>
CC:     Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
        <lgirdwood@gmail.com>, <thierry.reding@gmail.com>,
        <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-kernel@lists.codethink.co.uk>
References: <20180727125931.9794-1-jorge.sanjuan@codethink.co.uk>
 <20180727125931.9794-3-jorge.sanjuan@codethink.co.uk>
 <2392df6f-12bc-74fe-ec0f-50dbb7b9a33a@nvidia.com>
 <20180730101800.GF5789@sirena.org.uk>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <2a91268d-351b-d342-42bd-8ffbf33a316e@nvidia.com>
Date:   Mon, 30 Jul 2018 15:04:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180730101800.GF5789@sirena.org.uk>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30/07/18 11:18, Mark Brown wrote:
> On Mon, Jul 30, 2018 at 10:31:16AM +0100, Jon Hunter wrote:
> 
>> It can be quite common for the fsync-width for DSP modes to be a single clock and so 
>> I am not sure that is makes sense to set this here always to the slot width. It maybe
>> worth considering add a DT property for specifying the fsync width.
> 
> DSP modes only care about the rising edge of the LRCLK, the pulse can be
> any width without causing interoperability problems.

OK, thanks I was not able to find a spec that defines this, but I saw a
lot of codecs use a single bit clock width. So then equally making the
default '1' should also be fine.

I still do not like configuring the fsync width in this function. The
fsync width needs to be configured for both DSP modes and normal I2S
modes and so it seems it would be more appropriate to do this in the
hw_params function for this driver.

Cheers
Jon

-- 
nvpublic