Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4014841imm;
        Mon, 30 Jul 2018 07:17:53 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpc/ZkbZXrPYyvkTzFxPNnywQDGGJqqPF7wGxNvEwdxHmAeexkOyM4FwUwBJMUtaUEicbczk
X-Received: by 2002:a62:4255:: with SMTP id p82-v6mr18264756pfa.238.1532960273686;
        Mon, 30 Jul 2018 07:17:53 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1532960273; cv=none;
        d=google.com; s=arc-20160816;
        b=dx1gVOEcsSnj1i/mGUBP3sraITifSUBBKbst6hUBo8CR77SgLbJz183hnNA/mhM8Fe
         ys96MhWdCELgPPwv91sAuGPDU19ybPljnN8BDrbDawl5CzVsscf01dQT5a0lBAVukIAf
         qJ179m1P/J8tPBvwzKeXtLoxyIpngmwLh3E/rVJkdct7uF46qtu3tLW0FWd+her/Cih9
         FFhEu5VIUMYDweaj5we6WR+8axqgyAIoJP88rQ43X3IUEWex/hRTxSd2gogZpNoaeBXC
         xgqABKlLJbWLxcmLB2+HBWxv3/pG5PSHvGzpv/2RK00Jo0/IxUB0LIRErlHQkRiO5sCk
         7vYQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject:arc-authentication-results;
        bh=RtGvCMkRWUs9c96N46y5f7ygdffT7xnLI+rI3XNszFw=;
        b=GZWWCJ+oCY/dxi3CpN2iq/uynh0ibqDwSNkAH8sBU8oUXF5yOWenfHGF8ZRRAScpg8
         7zn1O4Z0GAv1Mz8KooMwKCQHq4t4nMm1DypyQ3oKRu9r9qGwnaGLNOo6mNWlhDMphPfe
         fNJXswhPc768HIhcbamaFNNdZKuNGPSepfatg+NyBV8tBLoO0xBTASOY4s+wamAC8NlR
         y16GcFQ71h3UiRzSAYy/p28QZqn77XEuVfjjAXNhTywqC9YOmdHjj6RbBUm7WomKwVtp
         g5zmlTrF2Q+CTTJTqa6TeFxCLExjINxqUk6u4Mlf3l/rub9ihrnUtEX0XSkC6OWToKb9
         03GA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f19-v6si5037970plr.244.2018.07.30.07.17.38;
        Mon, 30 Jul 2018 07:17:53 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731830AbeG3Pun (ORCPT <rfc822;rmelvin.vger@gmail.com>
        + 99 others); Mon, 30 Jul 2018 11:50:43 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:9818 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727057AbeG3Pun (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jul 2018 11:50:43 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b5f1d7f0001>; Mon, 30 Jul 2018 07:15:27 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 30 Jul 2018 07:15:30 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 30 Jul 2018 07:15:30 -0700
Received: from [10.21.132.122] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 30 Jul
 2018 14:15:28 +0000
Subject: Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback
From:   Jon Hunter <jonathanh@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
        <lgirdwood@gmail.com>, <thierry.reding@gmail.com>,
        <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-kernel@lists.codethink.co.uk>
References: <20180727125931.9794-1-jorge.sanjuan@codethink.co.uk>
 <20180727125931.9794-3-jorge.sanjuan@codethink.co.uk>
 <2392df6f-12bc-74fe-ec0f-50dbb7b9a33a@nvidia.com>
 <20180730101800.GF5789@sirena.org.uk>
 <2a91268d-351b-d342-42bd-8ffbf33a316e@nvidia.com>
Message-ID: <6b9fb98e-eb55-8b19-5c73-403064cb7b3a@nvidia.com>
Date:   Mon, 30 Jul 2018 15:15:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <2a91268d-351b-d342-42bd-8ffbf33a316e@nvidia.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30/07/18 15:04, Jon Hunter wrote:
> I still do not like configuring the fsync width in this function. The
> fsync width needs to be configured for both DSP modes and normal I2S
> modes and so it seems it would be more appropriate to do this in the
> hw_params function for this driver.

That said, it does not look like this current driver ever programs the
fsync width for normal I2S mode (which I thought was necessary as we do
in other Tegra I2S drivers). So I will check on this and confirm.

Jon

-- 
nvpublic