Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4046791imm; Mon, 30 Jul 2018 07:49:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe51xjRJyNjbXpFa4TJfQhDz+jw/+YRydEb+H6bxi7gfGAHTjBYwz4mJSlxLf9az6osbFA+ X-Received: by 2002:a63:d15:: with SMTP id c21-v6mr16920984pgl.322.1532962180076; Mon, 30 Jul 2018 07:49:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532962180; cv=none; d=google.com; s=arc-20160816; b=wLuZ5lHlWAdR2z6/HU3QRfDjb1hEdXyi8yK1pf50G3LYCiQR14QnzMB7DYRnouG8Zn lEtcAd1e5XPBmO1nTBFaDCfD5lWr5HRUvt4xQVfImpxqkWQzWsZaKwck/P6m/nHvJ60F vGFG76Raw3DIZm3k7pKacgb3nqloB5RMnCJZf1nCDKMf7UYWNI0FdYXxJE97X5CaGfcy fUwWsF1piJhquItP7mmJXWDn/VrAd3Q450T8emXXkwuGKDqBuHgE5hxTmSJnIr9p3zKr wbz59z9dG7Cfhd2bwjxNc6+tbaQr0yMQImLWboYnPWohbIiEpm+YHfxalFIm/xKqH1/W 3cJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=ArAqLpvdlhR4ChTkXWsd9QXZnwhByG070qLZp5TtBSY=; b=jDUUVcKJnZT2enLh1jQVNd8GU2et7TFjLhDOzvv0FC+jxh/Asnys1ouLInqQFj0Spe n9zYKSOegDDuDmEJRws3Yob9U9T4LC7R+ExDaBgikcsN2lVre49ix61UpSi/fQC4vNAH xt7tRJzBr6aNErJDN4Hl2oxb/ANbBa+Va5H9iYzOtcCew0gmuT3HWsO3AZsk8VhkZUCJ 0yXrUi91Fta6mQs/DiTR9jBripIZpojeNZRNP7QuUS0rGDBlAaQ+9vueUDFDQz0PnWa7 1Xt2Pvz75zEyLebaTYRWhkNAYd5jlnCcM+9fk76ArBD9jZvL+HDJp+rqHt9/cT1W2Hq6 P3QA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 13-v6si10292895ple.274.2018.07.30.07.49.26; Mon, 30 Jul 2018 07:49:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732042AbeG3QXv (ORCPT + 99 others); Mon, 30 Jul 2018 12:23:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35304 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731700AbeG3QXv (ORCPT ); Mon, 30 Jul 2018 12:23:51 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63DC040216FE; Mon, 30 Jul 2018 14:48:30 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-116.rdu2.redhat.com [10.10.120.116]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5606B2026D68; Mon, 30 Jul 2018 14:48:29 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <153271267980.9458.7640156373438016898.stgit@warthog.procyon.org.uk> <153271291017.9458.7827028432894772673.stgit@warthog.procyon.org.uk> To: Andy Lutomirski Cc: dhowells@redhat.com, Al Viro , Linux API , Linus Torvalds , Linux FS Devel , LKML Subject: Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6256.1532962108.1@warthog.procyon.org.uk> Date: Mon, 30 Jul 2018 15:48:28 +0100 Message-ID: <6257.1532962108@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 30 Jul 2018 14:48:30 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 30 Jul 2018 14:48:30 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski wrote: > Constants are almost always all caps. Is there any reason these are > lowercase? It's also easier to create macros that pair structs or functions with the contants by name. David