Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <14f411527d551411defdd73a2507a13b7f07e789.camel@perches.com>
References: <CAFGhKbzXiAx3iaveOQhXCseH2kg1U=j-sp0B9jNSF2wPUjDtFg@mail.gmail.com>
 <14f411527d551411defdd73a2507a13b7f07e789.camel@perches.com>
From:   Charlemagne Lasse <charlemagnelasse@gmail.com>
Date:   Mon, 30 Jul 2018 17:52:35 +0200
Message-ID: <CAFGhKby698K852CWEh3zF_cqoumCgnv7OXLXrN2L9s-E4knBnA@mail.gmail.com>
Subject: Re: checkpatch: SPDX integration breaks --root
To:     Joe Perches <joe@perches.com>
Cc:     Rob Herring <robh@kernel.org>, Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Does this work for you:
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f25f708cd2a7..f0e6913c5cc1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -852,7 +852,7 @@ sub is_maintained_obsolete {
>  sub is_SPDX_License_valid {
>         my ($license) = @_;
>
> -       return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py"));
> +       return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
>
>         my $status = `echo "$license" | python $root/scripts/spdxcheck.py -`;
>         return 0 if ($status ne "");

No, because $root is a git repository in my case (linux-next to be
exact). The problem here is that spdxcheck is ignoring $root and just
assumes that cwd is a linux git repository. And when it is one but not
a linux git repo then I get following error:

FAIL: "Blob or Tree named 'other' not found"
Traceback (most recent call last):
  File "/usr/src/linux-next/scripts/spdxcheck.py", line 234, in <module>
    spdx = read_spdxdata(repo)
  File "/usr/src/linux-next/scripts/spdxcheck.py", line 41, in read_spdxdata
    for el in lictree[d].traverse():
  File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line
298, in __getitem__
    return self.join(item)
  File "/usr/lib/python2.7/dist-packages/git/objects/tree.py", line 244, in join
    raise KeyError(msg % file)
KeyError: "Blob or Tree named 'other' not found"


Still, your change looks good when $root is pointing to an extracted
tarball with the linux sources and not to a full repository