Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4128693imm; Mon, 30 Jul 2018 09:07:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcsXwSOa3ztmZXjhLCeXRrHITy3Ez1oDiyRUdfUyGSyxbJWqsnHMQA4c9dT/v19ivX8wYFg X-Received: by 2002:a63:1d3:: with SMTP id 202-v6mr16796292pgb.136.1532966845511; Mon, 30 Jul 2018 09:07:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532966845; cv=none; d=google.com; s=arc-20160816; b=NMGP2Ebmq21JyPHzKy//7+Ch4u+eoNwJ5RwKifvGOog5brH/oAVj6m4/OyzMKImbW1 zzYhdQKIiyHVKfc7aKBOaZr1JbZzKDlURoQic206TIDrmv/AuJRW/22VgwUPst0B0qmR yCmPXJHlPoZCMs9p9eTQXehzWqXi2Wgs4+tsT1pnL/VhS+mCDjm79tmqlq/aL/ePHWZy Vu8CVktRQsCxMpnwDxVj4T/ZlZ2NaPxUG/rdFEzJNjA4uo+uzYw73U0kga4cw8RKxH7t HNgoOEXTPfAOTl8b4DNJgbkwSkNKJzR7TqJMcRCBTWTnCGek+owVyt8/8NUhWTJPWZ2T iXbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=L+VIkSFa32WNvqAm6kHI+MRIQu/zX4uMXmXB5pi+RW0=; b=kMUuFtE/l9R4p/f6oCLTmORkaeGt/0NQC7GCMQ4KoNbwY/5RIDuuGW0ptWQIk9YeWz m2Sbl3xXGZzqle9P01wqS2B53plZEPkTaxvO7UO+G5fmksI2bha03t6M+zMD/shJ6Zr0 2J7K8zf7AqHKRNout9rOK0m7YMdGLmUuExW0mxkLlOWGc6MM9qJ7FPCG5V7Z7tBE1qg+ tDFyuhYyGIhacgzSd56o1RwvYtHP7FvuJK2OcVeDz6GJe8Ej8v2dlo2QEeAhyadJAymy h8JexhqZbza/11RF2dQ5wZkpgE+QA7OoF+UoWr67KZ1MZZnYwyeN34n4hr9t7ZBDuuyU 5r8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3-v6si11558365pgq.354.2018.07.30.09.07.11; Mon, 30 Jul 2018 09:07:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728793AbeG3Rl2 (ORCPT + 99 others); Mon, 30 Jul 2018 13:41:28 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:43039 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbeG3Rl1 (ORCPT ); Mon, 30 Jul 2018 13:41:27 -0400 Received: from [148.252.241.226] (helo=[10.35.4.113]) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1fkAg7-00019D-FD; Mon, 30 Jul 2018 17:05:47 +0100 Subject: Re: [PATCH v2 1/4] ALSA: usb-audio: Initial Power Domain support To: Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20180719112215.4219-1-jorge.sanjuan@codethink.co.uk> <20180730092336.18741-1-jorge.sanjuan@codethink.co.uk> <20180730092336.18741-2-jorge.sanjuan@codethink.co.uk> From: Jorge Message-ID: Date: Mon, 30 Jul 2018 17:05:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/18 14:03, Takashi Iwai wrote: > On Mon, 30 Jul 2018 11:23:33 +0200, > Jorge Sanjuan wrote: >> >> diff --git a/include/linux/usb/audio-v3.h b/include/linux/usb/audio-v3.h >> index 334bfa6dfb47..786e5939d831 100644 >> --- a/include/linux/usb/audio-v3.h >> +++ b/include/linux/usb/audio-v3.h >> @@ -447,4 +447,8 @@ struct uac3_interrupt_data_msg { >> /* BADD sample rate is always fixed to 48kHz */ >> #define UAC3_BADD_SAMPLING_RATE 48000 >> >> +/* BADD power domains recovery times */ >> +#define UAC3_BADD_PD_RECOVER_D1D0 0x0258 >> +#define UAC3_BADD_PD_RECOVER_D2D0 0x1770 > > Please put the unit for these values. I guess they don't need to be > hex? > Hi! The BADD spec defines these inferred values as hex (see section 6.2.2.13 of the spec). Should we keep them as per spec to avoid confusion? I'll update comment there with the units (50 us increments). Thanks for the reviews today. I'll update this series soon with the suggested changes. Jorge > > Takashi >