Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Jul 2018 18:10:37 +0200
Message-ID: <s5hmuu8r9fm.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Jorge <jorge.sanjuan@codethink.co.uk>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ALSA: usb-audio: Initial Power Domain support
In-Reply-To: <dcca62da-db80-5081-4552-2a010b307656@codethink.co.uk>
References: <20180719112215.4219-1-jorge.sanjuan@codethink.co.uk>
        <20180730092336.18741-1-jorge.sanjuan@codethink.co.uk>
        <20180730092336.18741-2-jorge.sanjuan@codethink.co.uk>
        <s5hbmaox4dh.wl-tiwai@suse.de>
        <dcca62da-db80-5081-4552-2a010b307656@codethink.co.uk>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 30 Jul 2018 18:05:47 +0200,
Jorge wrote:
> 
> 
> 
> On 30/07/18 14:03, Takashi Iwai wrote:
> > On Mon, 30 Jul 2018 11:23:33 +0200,
> > Jorge Sanjuan wrote:
> >>
> >> diff --git a/include/linux/usb/audio-v3.h b/include/linux/usb/audio-v3.h
> >> index 334bfa6dfb47..786e5939d831 100644
> >> --- a/include/linux/usb/audio-v3.h
> >> +++ b/include/linux/usb/audio-v3.h
> >> @@ -447,4 +447,8 @@ struct uac3_interrupt_data_msg {
> >>  /* BADD sample rate is always fixed to 48kHz */
> >>  #define UAC3_BADD_SAMPLING_RATE				48000
> >>  
> >> +/* BADD power domains recovery times */
> >> +#define UAC3_BADD_PD_RECOVER_D1D0			0x0258
> >> +#define UAC3_BADD_PD_RECOVER_D2D0			0x1770
> > 
> > Please put the unit for these values.  I guess they don't need to be
> > hex?
> > 
> 
> Hi!
> 
> The BADD spec defines these inferred values as hex (see section 6.2.2.13
> of the spec). Should we keep them as per spec to avoid confusion? I'll
> update comment there with the units (50 us increments).

Well, if they were defined in hex, it makes sense to keep the raw
values as is.  But it'd be also helpful to give a comment showing the
actual usecs.


thanks,

Takashi