Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4156870imm; Mon, 30 Jul 2018 09:34:11 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeIS8+a9ztFyek0bK32OoYI3e8lY4TPc4yJgj9R/3kwF3KShW2jUrRa+5EOgIaY5aHyzWJP X-Received: by 2002:a63:d74f:: with SMTP id w15-v6mr8197749pgi.306.1532968451186; Mon, 30 Jul 2018 09:34:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532968451; cv=none; d=google.com; s=arc-20160816; b=VFdZUD7qUUnI/zf9QG9dyLrJw/7a6w6eE7WuAoz0BNwWRizpxs1nWXm721ofg8QD52 /gzWzqcdMDv+ZIW6Yu4yEnk/j0l2o6xBNqVkXSS6jfiKhNiXCYPtocm6MJP4p/2FVSit RUzFFyWNlg9W3B7FIGKpdV5PekOkiIRjAlj6AYIV9Oj1l8947Z8WdaZsOfo1Rje3RKVy r6dlm7StORX5lhuhMsf22hndou66+MtvKoWzyGphK55i+fuYiaym0zQx91mYDhzOhUAK PIPRer+ubIAtK7mb7XoxcuSe3UnwjiLbVRulJiQiuHaLowreqU1b8NyOzG+N+3cnqu50 n8qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=bTfDzwZyZnXzpXueRbgYjm/0lnZsq4/nyMfoI+GhAcQ=; b=zYkbt6uClPknaBfQJa023w0IK0+G2ngYqegPMi33BZLuFssJRdN614ZqteRlQZioZR Ed1Fq66iel7MECYujSHWFGkrCAG5DBwJ5u8k7l1pAQONCQitrRTDDPzgmhKWLCIK7Srd cxslETa3QzcYd3QZPAexe5VrUozoOD96EB+ADU6tro8LsmC1D9Bp9y34tzXa5T/5X0Sa jvfLLpK5CmmIyolPKOCmsWSp3gYAFnCBYfNS04RK65Z3km/dW+8aZhFQD43c/NcL+gS5 gnYOmPuKmW+Qfpn3U0htnF56RCzYPW4EvuGOR6ucXzTX6mb5aZUxitfKsru5J4+TY+TQ 0FcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=AYSqcDXX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w126-v6si11289588pgb.11.2018.07.30.09.33.56; Mon, 30 Jul 2018 09:34:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=AYSqcDXX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732067AbeG3SIU (ORCPT + 99 others); Mon, 30 Jul 2018 14:08:20 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37004 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbeG3SIT (ORCPT ); Mon, 30 Jul 2018 14:08:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bTfDzwZyZnXzpXueRbgYjm/0lnZsq4/nyMfoI+GhAcQ=; b=AYSqcDXXkkc7P7Z1VlKiWG/dE ptkxrLOKjMupqYeyvJA9lM+ZtzmExR4nRtwop477hW0fRzLH4TLTzDrw3oS1ebRddovBDKgcvgU8N PT14a2bQCT6/mFmF1Lfrsqy6nUW3KW/ju1d2m3DNANtjzF38qWUU3HSKZH29w+9yRdb4/5gMny3im 5X0zDJ2+pEi7wIrwqx4KS3XIGyozO9Ay4uGqAzUeuxnt98RGha2I3wQfXkO57merWzOHI/UZ3wp+5 DUrKR7ww/OCSyE5yEuomRa3/Y/kR3fXgl/9UmfjThfBXUweVfrNdIT4ZgdmjyIaYrGKger/sw+2Qa iRrSon2bQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkB5z-0001Gj-ST; Mon, 30 Jul 2018 16:32:31 +0000 Date: Mon, 30 Jul 2018 09:32:31 -0700 From: Christoph Hellwig To: Christian Brauner Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, tkjos@android.com, maco@android.com, rlove@google.com, ben@decadent.org.uk Subject: Re: [PATCH 2/4] file: export __fd_install() Message-ID: <20180730163231.GB27761@infradead.org> References: <20180730143710.14413-1-christian@brauner.io> <20180730143710.14413-3-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180730143710.14413-3-christian@brauner.io> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2018 at 04:37:08PM +0200, Christian Brauner wrote: > The Android binder driver will be turned into a module. Since it > uses __fd_install() we need to export this function. Same as the previous one. No driver should be pooking this deep into fd internals (not even non-modular ones for that matter).