Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4157606imm; Mon, 30 Jul 2018 09:34:58 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfeSIcKZ9QhwlxHA1/Om1bZ+rwPRBBJoaTITLgwVo2pXzU37Vp/a9ZpTaWrKQ9PIyUtsv/7 X-Received: by 2002:a63:4703:: with SMTP id u3-v6mr16557876pga.405.1532968498001; Mon, 30 Jul 2018 09:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532968497; cv=none; d=google.com; s=arc-20160816; b=C4L3fJIb9mNm9GzUu4R/diUQt8o9g/dlPdxCc2ST+YRUEVLXyXQZboD3DZ1iUOJ0yU V2U97gOJ+BHQSWXb27p+VyqtH6gVR6P/9c6u2pedm2ual/F5eT7vOQhKcLA0fT/Tem6v QzYRaE5Vwqq4ovhLixmZyE/TqRM3V8uqveWrYJTjcVPZYc4ENXF+IkttkQc8DxfhSKq4 WsMAt5zN/KKSQtvEdW28P6fsV8Fm/7RChoDkZTKQGHp7QbWGy/cTtI9VkR0Ivlawo+kc iFOj9C47vmQVWjgLvepn44CUfOPygnNVaYJxb8C57BvwVTyFmt8rHD1ryGGWuXyNxB0p Bbng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ng1Ksu9UfOmFki+NlsUzbwn4VFbgolVQqoXEKm4o7fE=; b=FvpdRA1zTRwM+i21uVYpzkgW2399hKJKRFx+w5LM7qGfb1Llcvn8uxkD8mNthbXNSK CEh42a4jIL6r0ehVIanx/mJnjJWFFpumOKWSFF5t2Svcbkp/OjzLctEDwFLdlLpz47wC mPXUgp0UAGiPThQGkmMKhKa88GgRjA6DhIV7cgZ07SKHfF1/Hv/4iG7+3WHu+L8oQtBa 5mz/xwlZrR5mN5EheL91tarxfDHYZ/sFnTcFcb1B9tL5J5/MpaP4/K7ZTQhp+HgYb50h A3kp6Cq2toHmvnqUP9WSN2f3dLK42kZzy0+1nq7qD+vSBqBkZ6O9hylRRIeM/ExNjNe7 XEZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="ML3t7u/O"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7-v6si9832661plp.363.2018.07.30.09.34.43; Mon, 30 Jul 2018 09:34:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="ML3t7u/O"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732082AbeG3SIp (ORCPT + 99 others); Mon, 30 Jul 2018 14:08:45 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:37018 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731633AbeG3SIp (ORCPT ); Mon, 30 Jul 2018 14:08:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ng1Ksu9UfOmFki+NlsUzbwn4VFbgolVQqoXEKm4o7fE=; b=ML3t7u/Ok8/DYhFlmDewSJgSh q5fmgJmCCNPpvH30ngxK1Ds8lubyvE5FPHesjEEgmDKKbI+I0WN/yeNky2+Qc8aihikubXN6aSk/s rFsrEBxCFSHqQm59K1pCpxNrTsioJ+nSsUn6Eij4mEKttXDDPaf6FzT1j8Ol5bAET9iFFLjS9QV5y AvUiujk8Yv93HsaEswtHrQfFB4Xt32Iu2RizSoYpLqctiDcZ6wwPoIuqRbFS/wFuCZfuRddSsduvX dHrLcYc+xY7LetkLlXLX4B2Cg72zCHW2HlW9afuaEtZYqD2cTzlha+EFvELb6qtND79W7cLFB/xKK Z4Opnl8vQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkB6O-0003x1-Qq; Mon, 30 Jul 2018 16:32:56 +0000 Date: Mon, 30 Jul 2018 09:32:56 -0700 From: Christoph Hellwig To: Christian Brauner Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, tkjos@android.com, maco@android.com, rlove@google.com, ben@decadent.org.uk Subject: Re: [PATCH 3/4] file: export get_files_struct() Message-ID: <20180730163256.GC27761@infradead.org> References: <20180730143710.14413-1-christian@brauner.io> <20180730143710.14413-4-christian@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180730143710.14413-4-christian@brauner.io> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2018 at 04:37:09PM +0200, Christian Brauner wrote: > The Android binder driver will be turned into a module. Since it uses > get_files_struct() we need to export this function. Hell no. Please explain why so that we can find a better way.