Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Jul 2018 19:16:08 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Sodagudi Prasad <psodagud@codeaurora.org>
cc:     Peter Zijlstra <peterz@infradead.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        isaacm@codeaurora.org, matt@codeblueprint.co.uk, mingo@kernel.org,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        pkondeti@codeaurora.org, stable@vger.kernel.org
Subject: Re: [PATCH] stop_machine: Disable preemption after queueing stopper
 threads
In-Reply-To: <109d0e70606ccd34861a80525d6d11aa@codeaurora.org>
Message-ID: <alpine.DEB.2.21.1807301913250.1725@nanos.tec.linutronix.de>
References: <1531856129-9871-1-git-send-email-isaacm@codeaurora.org> <a30d1e147d3181fc7b294262e380a10c@codeaurora.org> <20180724062350.nlem2suuy5wlxpts@linutronix.de> <alpine.DEB.2.21.1807301220280.2518@nanos.tec.linutronix.de> <20180730112140.GH2494@hirez.programming.kicks-ass.net>
 <alpine.DEB.2.21.1807301440340.2518@nanos.tec.linutronix.de> <109d0e70606ccd34861a80525d6d11aa@codeaurora.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 30 Jul 2018, Sodagudi Prasad wrote:
> How about including below change as well?  Currently, there is no way to

That would be a completely separate change.

> identify thread migrations completed or not.  When we observe this issue, the
> symptom was work queue lock up. It is better to have some timeout here and
> induce the bug_on.

BUG_ON() is wrong. Why kill the thing if there is at least a theoretical
chance that stuff can continue half baken so you can get more info out of
it. The back trace is pretty much uninteresting.

Thanks,

	tglx