Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4309339imm;
        Mon, 30 Jul 2018 12:11:29 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpeuRVYEO5raVbFcfvL+xSw8Fm1q+R4tzgAsbtPk+RRKHsPiD7K6JdU+xi8vJmUmTSIaP2EK
X-Received: by 2002:a17:902:8210:: with SMTP id x16-v6mr17500654pln.307.1532977889557;
        Mon, 30 Jul 2018 12:11:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1532977889; cv=none;
        d=google.com; s=arc-20160816;
        b=N0KAVx4jiFhgGvi7gMYmwJUqxlIDkS0sXHRaj2jr8x8pBvSWjVzt7Xpqk3GTJzsFub
         4RePr+22rPF3QMwinJnyTc58ZyJXzaFJ55rysuv+7lz7P8IAD4Xjyb7Q96hVA5VJPMAv
         TgAVoeRx5VcuO40xdCSwVEPQiWWK+TMYT2MDwy53mpZF5YZunWniPVk9JntF7Cpspka8
         D9InjqE0fEvZhmy0ZXevVbceJcCJ5UA/UxBeVPUsELcqhydQLgpKGS9MOmxRi8BFmgzV
         xuAdmyfmSMiKfXfZELMjcPv2Jd7mRd7hruJG5ts4Kd/v4Glh/xcBw1vQuZfllwisan4n
         /pfA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature:arc-authentication-results;
        bh=oIdRcrtxJixbdDtaMxZh3ruy/zY1NQN5G8BZo6ddkoY=;
        b=NGnJ09XLjue1nKqhCkV4ovAG94zqdRrkutb2Wk6o2rISJDqctlk3h7nmJJIKFW7lGh
         HVy9MSv4B3wy27sYGGnaQgygY9JxLnMsnQbm+0lhmGewmqSyelOlgoxF3pljPlMDac+q
         NvMW0mtDc1S2inoPgO766x3YFpojTMhltL/8W86D8tgwiUOKWWtGJ/Ke1r1cFXoMdd8F
         DA9ie8lcw6I+4TTPzs7VxIXItx77nR2EpLc9ocwKkfyv4GKONHAUSPMgaunKZXzk8JkP
         YqqTFm4/FTzwmiqQ5XlCjIltreyyIYOQ3IZDvrt5cjCFBu/EJplNMLuOcnxSU7O/udKD
         vy9Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=d1jkLLOi;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id x5-v6si12688162pgx.310.2018.07.30.12.11.15;
        Mon, 30 Jul 2018 12:11:29 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=d1jkLLOi;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732000AbeG3UqG (ORCPT <rfc822;rmelvin.vger@gmail.com>
        + 99 others); Mon, 30 Jul 2018 16:46:06 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:50799 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731600AbeG3UqG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jul 2018 16:46:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124;
        h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=oIdRcrtxJixbdDtaMxZh3ruy/zY1NQN5G8BZo6ddkoY=;
        b=d1jkLLOiBWPj7O0938v/l9y6Yt+FsCKz/HZymevtBokaIYHEA9l3jCt5PeyzBcdrQHqXz3uVuKYk+iALm67V4rzs+pRKc/PI2flI345nhRQvBi9pJ0W1gFvdrUZ0Kh37Hjq4TOObd5OZTwDoPh4vwENxr2k4WtguPkp6PdTUQMU=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2)
        (envelope-from <andrew@lunn.ch>)
        id 1fkDY5-0002Zt-AW; Mon, 30 Jul 2018 21:09:41 +0200
Date:   Mon, 30 Jul 2018 21:09:41 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jiri Pirko <jiri@resnulli.us>,
        David Miller <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Roopa Prabhu <roopa@cumulusnetworks.com>,
        Jakub Kicinski <kubakici@wp.pl>,
        "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [RFC PATCH net-next v2 10/17] ethtool: implement GET_SETTINGS
 message
Message-ID: <20180730190941.GL2983@lunn.ch>
References: <cover.1532953989.git.mkubecek@suse.cz>
 <67d3b68a50e95db9612cc96e42a52ce332f716a9.1532953989.git.mkubecek@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67d3b68a50e95db9612cc96e42a52ce332f716a9.1532953989.git.mkubecek@suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +Response contents:
> +
> +    ETHA_SETTINGS_LINK		(u32)		link state

> +	[ETHA_SETTINGS_LINK]		= { .type = NLA_FLAG },

Is this correct?

The link is either up or down. So a u32 seems a bit big.

    Andrew