Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 30 Jul 2018 15:28:01 -0400
From:   Don Zickus <dzickus@redhat.com>
To:     Sinan Kaya <okaya@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Colin Ian King <colin.king@canonical.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] watchdog: Reduce message verbosity
Message-ID: <20180730192800.nqdhugzbxmin6e25@redhat.com>
References: <20180730190949.141996-1-okaya@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180730190949.141996-1-okaya@kernel.org>
User-Agent: NeoMutt/20180622
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 30, 2018 at 12:09:47PM -0700, Sinan Kaya wrote:
> Reducing the verbosity level to debug for people that are interested in
> debugging watchdog issues.
> 
> [    0.152492] NMI watchdog: Perf event create on CPU 0 failed with -2
> [    0.156002] NMI watchdog: Perf NMI watchdog permanently disabled

Hi Sinan,

Any reason why?  Usually when the 'perf event' fails, that indicates a
system problem.  And most folks don't boot with the 'debug' option.  This
means these unusual failures are hidden and become difficult to debug later
when it propagates.

Or are you running the watchdog in a different configuration such that this
is a common nuisance that you are trying to suppress?

Cheers,
Don

> 
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>  kernel/watchdog_hld.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/watchdog_hld.c b/kernel/watchdog_hld.c
> index e449a23e9d59..1f7020d65d0a 100644
> --- a/kernel/watchdog_hld.c
> +++ b/kernel/watchdog_hld.c
> @@ -175,8 +175,8 @@ static int hardlockup_detector_event_create(void)
>  	evt = perf_event_create_kernel_counter(wd_attr, cpu, NULL,
>  					       watchdog_overflow_callback, NULL);
>  	if (IS_ERR(evt)) {
> -		pr_info("Perf event create on CPU %d failed with %ld\n", cpu,
> -			PTR_ERR(evt));
> +		pr_debug("Perf event create on CPU %d failed with %ld\n", cpu,
> +			 PTR_ERR(evt));
>  		return PTR_ERR(evt);
>  	}
>  	this_cpu_write(watchdog_ev, evt);
> -- 
> 2.17.1
>