Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] watchdog: Reduce message verbosity
To:     Don Zickus <dzickus@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Colin Ian King <colin.king@canonical.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <20180730190949.141996-1-okaya@kernel.org>
 <20180730192800.nqdhugzbxmin6e25@redhat.com>
From:   Sinan Kaya <okaya@kernel.org>
Message-ID: <4e5def8b-df29-0efb-7e35-e71070e94d91@kernel.org>
Date:   Mon, 30 Jul 2018 12:43:34 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180730192800.nqdhugzbxmin6e25@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Don,

On 7/30/2018 12:28 PM, Don Zickus wrote:
>> [    0.152492] NMI watchdog: Perf event create on CPU 0 failed with -2
>> [    0.156002] NMI watchdog: Perf NMI watchdog permanently disabled
> Hi Sinan,
> 
> Any reason why?  Usually when the 'perf event' fails, that indicates a
> system problem.  And most folks don't boot with the 'debug' option.  This
> means these unusual failures are hidden and become difficult to debug later
> when it propagates.

Sorry, I should have been more clear. I'm only suppressing the first
error message.

[    0.152492] NMI watchdog: Perf event create on CPU 0 failed with -2

Second message is still visible during boot. User knows that NMI 
watchdog is disabled.

[    0.156002] NMI watchdog: Perf NMI watchdog permanently disabled

Code is trying to probe the platform capabilities and is failing
because of missing PMU in the system. If someone is interested in
finding out why watchdog was disabled, they can turn on the debug
message level.

> 
> Or are you running the watchdog in a different configuration such that this
> is a common nuisance that you are trying to suppress?

Yup, system doesn't support PMU.

> 
> Cheers,
> Don
> 

Sinan