Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4361840imm; Mon, 30 Jul 2018 13:13:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe+MG4IRKhiWakDbbrJ/4Dace5or/l5PocNVcpcab7tCR55mONsO3Tq+YYQR17BWYJ+Vg2b X-Received: by 2002:a62:5543:: with SMTP id j64-v6mr19123154pfb.188.1532981611834; Mon, 30 Jul 2018 13:13:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532981611; cv=none; d=google.com; s=arc-20160816; b=hgp8EWRgIVTk8Z3EuZuNkdGVFl3LL4xAh7BtTntDxm+AdRDovSP1K8GJfLHzsWrhyH YFXz3+5RzFlTiAJj13U1PrKuIvRBmepzuW318MB9HKjPEpzVHgLYKUunBTQ8bjvv5MtZ JmlcHDhgn1yhFIR8eDOsz9efzWKFdpf491KbWOroKZhMabGTJNHOcvTkegwWLhUdi9m5 mdc/jLy+gIXyq8Qk6EqhavGagrIzvLKCX1TsC8ImYZxmUT+YOXZJFVESICq5aJiBjAlo gkZ2xNr0behePtPBhsmVo8mWUSwQBMHAz6EKSzT474+3CLsF+U4ATs0RaMIYfSAONW6s xN+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=whdF8Cz9w+1m5X0FTBTmjMCzzyIJ2CG5/k5kgqDONHs=; b=SfmUIzzcF3eJgfZPXiTTfhFRnY53DzUcyns95ubQrOD2/5Xw6WX779crMxb27VUP4L uvTiRL+TE+mF5rYq/xeCl7J1WKLfUJy662SnsHJglen6j0UplvavRpuM7L+SezvkMC/r eUclNMrjYPOITQTpBG/JMq/AwXlExOF3XJorM8tHAv36xEL4nJrmtUPJFY73W1DpKmiB AgQSf3UOGBUgGp2R7uKHuS7l9Iy640zO2NjbL2Vk0rb0nckp6YVdFSQBPIWAO/m93fUs chRFizFFpEKPkVTsin75DsHBs3brWtlGdZ5I2emcPkMCRcoq0P6UJSoVeDhi9mtz5o0G QS5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si11637850pgc.233.2018.07.30.13.13.16; Mon, 30 Jul 2018 13:13:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731768AbeG3VtH (ORCPT + 99 others); Mon, 30 Jul 2018 17:49:07 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:54746 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbeG3VtH (ORCPT ); Mon, 30 Jul 2018 17:49:07 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 7570F41261; Mon, 30 Jul 2018 22:12:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id 1ryoGEQRvRgD; Mon, 30 Jul 2018 22:12:26 +0200 (CEST) Date: Mon, 30 Jul 2018 22:12:24 +0200 From: Christian Brauner To: Christoph Hellwig Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, tkjos@android.com, maco@android.com, rlove@google.com, ben@decadent.org.uk Subject: Re: [RFC PATCH 0/4] file: export functions for binder module Message-ID: <20180730201224.GA1081@mailbox.org> References: <20180730143710.14413-1-christian@brauner.io> <20180730163452.GE27761@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180730163452.GE27761@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2018 at 09:34:52AM -0700, Christoph Hellwig wrote: > On Mon, Jul 30, 2018 at 04:37:06PM +0200, Christian Brauner wrote: > > Hey, > > > > We currently plan on turning the Android binder and ashmem driver into a > > module. We have seen more and more requests by users to be able to use > > the binder and ashmem features without wanting to convince each distro > > to enable it by default in their kernel. Debian already started to carry > > patches for turning them into modules. > > Yikes. I really wish Debian would stick more to upstream rather than > picking random crap like this up. Thanks for the review, Christoph. Unfortunately the gist of the message got cut off: > I don't expect this patch to be mergeable but rather to kick-off a > discussion if we can either simply export them as they are or how we can > get supportable exports that allow access to struct files_struct. Maybe that wasn't obvious from the first message. Is there any way we can come up with a way to have versions of these functions that you would be fine with exporting? The point is that otherwise we would have to either duplicate the code or come up with something way more complex. If you have any pointer that would already help. Christian