Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   NeilBrown <neil@brown.name>
To:     Nishad Kamdar <nishadkamdar@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Tue, 31 Jul 2018 08:10:43 +1000
Cc:     Christian =?utf-8?Q?L=C3=BCtke-Stetzkamp?= <christian@lkamp.de>,
        John Crispin <blogic@openwrt.org>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h
In-Reply-To: <20180727160733.GA10467@nishad>
References: <20180727160733.GA10467@nishad>
Message-ID: <87muu8l6ho.fsf@notabene.neil.brown.name>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 27 2018, Nishad Kamdar wrote:

> Replace explicit shifting with BIT macro in board.h.
> Issue found by checkpatch.
>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>

Reviewed-by: NeilBrown <neil@brown.name>

Thanks,
NeilBrown

> ---
>  drivers/staging/mt7621-mmc/board.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-=
mmc/board.h
> index a7d82f321b00..983791ee308d 100644
> --- a/drivers/staging/mt7621-mmc/board.h
> +++ b/drivers/staging/mt7621-mmc/board.h
> @@ -36,10 +36,10 @@
>  #ifndef __ARCH_ARM_MACH_BOARD_H
>  #define __ARCH_ARM_MACH_BOARD_H
>=20=20
> -#define MSDC_CD_PIN_EN      (1 << 0)  /* card detection pin is wired   */
> -#define MSDC_WP_PIN_EN      (1 << 1)  /* write protection pin is wired */
> -#define MSDC_RST_PIN_EN     (1 << 2)  /* emmc reset pin is wired       */
> -#define MSDC_REMOVABLE      (1 << 5)  /* removable slot                */
> +#define MSDC_CD_PIN_EN      BIT(0)  /* card detection pin is wired   */
> +#define MSDC_WP_PIN_EN      BIT(1)  /* write protection pin is wired */
> +#define MSDC_RST_PIN_EN     BIT(2)  /* emmc reset pin is wired       */
> +#define MSDC_REMOVABLE      BIT(5)  /* removable slot                */
>=20=20
>  #define MSDC_SMPL_RISING    (0)
>  #define MSDC_SMPL_FALLING   (1)
> --=20
> 2.17.1

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAltfjOYACgkQOeye3VZi
gbkm9A//R2oeRHsq/v8i7dWZZkVkpJ2ghbJ6mpgG5tEj1r+Pyfx19weKLmriqP09
VR00XPeiM8BXFxWZ0f0BvduyDf7UQqgqIWz2FVV/2l2eLWIfnKgJt8DB8OIqm+oB
c/SPDAEI5eA9TTQF+U8dl0NPY92SP8WGhjHLK8YQ94BLVXpDEvX6vkB/NYlobJzG
qSlm2WQ5W4LOGQuLMOErELB1AXGNdHWgxUm2YdiuUjqtuyE2nmUpOUQbLDmOkAEr
sZy5LPIzh4pzCfNnJxBIFFHtpSOW/cKvxSWzBjqiexjT7Q+4LGjsIZRVfJ47RWwk
sUlXb/CZKFxlUxAtgCgG4aYi1Jmns+XW+vVCH2P9WXZx55RVO7RJaXUQUzteSoFk
RzZbULDNxkk8EY8Rt5yCufIaJYu+vOHI/Q3S7CFfUuUqCwcOeT+FGzsNmxWg07LX
tFwzWI96hdsBGYwyyICVcdeyS18zcE9/hpXEfsVzAmHVETysJGuoC9gqIFOBBQ7a
cuuCnPb+8+IXKJhgmhSvhuFOyxr2znX4f5rmGo+SMnJ3sBzJlAkxDxWwQiBCGxSD
e5YkZg1zGnnEJ5wQpquBqjucIwANJHapuGrH2Q8IWPkg0YFgMIisnSEACbpxjXA3
EA0rgROxlIwpIF7g6Fyx+e6SS0TIRBGWUxUJdZCObTlDdkR4KSo=
=s3CJ
-----END PGP SIGNATURE-----
--=-=-=--