Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4561837imm; Mon, 30 Jul 2018 17:42:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf8OCVBRqNQ36xw9s5XhX65XVlc/jd31FEjGAK+wh8TmYdTS7h/UGcQ7Kb6ZcFcqXZCZDyU X-Received: by 2002:a17:902:9681:: with SMTP id n1-v6mr18917617plp.244.1532997775075; Mon, 30 Jul 2018 17:42:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532997775; cv=none; d=google.com; s=arc-20160816; b=xTCEAfrfX7lT8uY01aYnAFF45KsvCRXYghf77fNa6juuwVpCM8LFPSkBhGde6V1G0u 6Yl/Y7SQ4CdZmhFd2DsNnvd30VHWy13wB/tJ5lZUqLaZJXFFW00dE/jvvmhi8Nzpb8gO p2F+OTMHbdT6dRJAlzQvMGgkYh1/3Pyn+qHtpqH6fOsk+YM+wx/4hA1h9tNklN68zeum lQ9MJWIFSxgitxpouMyRTwCRiljBIpxjIRJC5ZpU3FR9LuXrN8fFY1qvS6srXsS5OD2e WqGduen5+7IJsCJNUkigg6wEOCc8xuA0sRbvkmP8qqpEsL5cH5cNtR0X9MdGrZjVMiTQ SSug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=T7Z37qquT6jxhQplQC9YbdqrL/7bk8ctwD3Jb2cOcHE=; b=mkR/SSfs3Y8pbLezKEFeF/BA59rnqRD8HihEc/adbKysGRW0JealMX/+gV5QnmK33U d7eDLV/caVtlPC90AWRQA1A6Wjkkf1Xxk4MU3IfNcW2kbcj+utlrly2p9OcOv4R06mWU 1aPFGvjCoXvzcIuhcE0tiI1+TAlEEM6Bj8hnDKP48XpV6M+Rwd4tyIrhVu98D78eRpi4 pgOc0wGbdPMWE7D9qxiaQEyEcA72d4hyq2eKGo0cSV5HpwMZOfmQKgH/aMWb84x3+wYh vmBV0CnjCbJEefE9Pc/S0mIpC3orTC6R2FDGKc0Ayt7I6dEJ6rhRg6HdszcmftNn0OOb gXyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay1-v6si10728655plb.266.2018.07.30.17.42.40; Mon, 30 Jul 2018 17:42:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732215AbeGaCRh (ORCPT + 99 others); Mon, 30 Jul 2018 22:17:37 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732191AbeGaCRh (ORCPT ); Mon, 30 Jul 2018 22:17:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E65697DAC6; Tue, 31 Jul 2018 00:40:03 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-11.bss.redhat.com [10.20.1.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95522178BC; Tue, 31 Jul 2018 00:40:03 +0000 (UTC) From: Lyude Paul To: nouveau@lists.freedesktop.org Cc: Lukas Wunner , Peter Ujfalusi , stable@vger.kernel.org, Ben Skeggs , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/8] drm/nouveau: Enable polling even if we have runtime PM Date: Mon, 30 Jul 2018 20:39:47 -0400 Message-Id: <20180731003954.19962-3-lyude@redhat.com> In-Reply-To: <20180731003954.19962-1-lyude@redhat.com> References: <20180731003954.19962-1-lyude@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 31 Jul 2018 00:40:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 31 Jul 2018 00:40:03 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lyude@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having runtime PM makes no difference on whether or not we want polling, and it's now safe to just enable polling unconditionally in drm_load() thanks to d61a5c106351 ("drm/nouveau: Fix deadlock on runtime suspend") Signed-off-by: Lyude Paul Cc: Lukas Wunner Cc: Peter Ujfalusi Cc: stable@vger.kernel.org --- drivers/gpu/drm/nouveau/nouveau_drm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 5fdc1fbe2ee5..ee2546db09c9 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -592,10 +592,11 @@ nouveau_drm_load(struct drm_device *dev, unsigned long flags) pm_runtime_allow(dev->dev); pm_runtime_mark_last_busy(dev->dev); pm_runtime_put(dev->dev); - } else { - /* enable polling for external displays */ - drm_kms_helper_poll_enable(dev); } + + /* enable polling for connectors without hpd */ + drm_kms_helper_poll_enable(dev); + return 0; fail_dispinit: -- 2.17.1