Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4607029imm; Mon, 30 Jul 2018 18:51:15 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdAsZEcYXnoGpJoZz8ymiPVOBPVJJSbK8HCSakAASC42EYCbctPimjzDtNBhMehodqLglhZ X-Received: by 2002:a62:9683:: with SMTP id s3-v6mr20198987pfk.191.1533001875261; Mon, 30 Jul 2018 18:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533001875; cv=none; d=google.com; s=arc-20160816; b=uNANfO6Up/VC6w5TbpFnJgSEZVyQM2O7peisXe6feFb2WFcV6RSQz9mIhXkNVv5H7S QRig5oJdWmjEGIfZqq0UOsnnNWCSruoY33XSsJYH3Qh6UnT9XUzE3VqbzRDK6EV7Qjn6 wUw59l7bEwaNfwVGUyWIFnqZYA2cz6ZIQ/XcYsvfCZ1ThG7cE/faoRUIpuOZA9gk5D4c HuJV41OTSVIOL8WN0OcW4Ly+ZEKtdTCZvO6eDeRF+bKZUiGcrYPS9hFS8ZjNs+itTaiC R0ChLusBeFG2tdEOliIawstKzZHIxhpGsy8vo5sWuyz3MP4ydAWOKCf0HiEtP8Z8ocd4 0xJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=WZ/VqO0Y5Z2+nzfW9+St0EhhfoPl1nEoc/n2L7EZdvw=; b=Uk1W67yzz9OlTNiCH8Z/0k4OyLUa4I2S1m9Nwcy28+0+tkmXSzF8MRVnmKWMOxmqwW 1uSWBvmEIU0Kxh+7kSFdFNuWf+7HYMCzxexE+fTztcmhSyiUIOhYF665POTy0W+jg4js pLCHegwSwS3EQZf73rrCMySKw7+NaFeMUtoZ4YneIz1kGul0YKBNZlvutemMOfC8ZSFU A9sa419+a2v1K63PQywcQp5GwCwjs3YMH59Y7iuN0akbyNrWWsgneaN8CnfkIE0oTN9P mOIuTftBThajEnGvcUAMgUPYA1+G/sxEhqOPz9QShcUreaN9Y3XhvpfJECeDHwJynRKH NuQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=v62vbgbH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h65-v6si12651844pfg.197.2018.07.30.18.50.59; Mon, 30 Jul 2018 18:51:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=v62vbgbH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730841AbeGaD1V (ORCPT + 99 others); Mon, 30 Jul 2018 23:27:21 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34785 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726659AbeGaD1V (ORCPT ); Mon, 30 Jul 2018 23:27:21 -0400 Received: by mail-pg1-f195.google.com with SMTP id y5-v6so8219976pgv.1 for ; Mon, 30 Jul 2018 18:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=WZ/VqO0Y5Z2+nzfW9+St0EhhfoPl1nEoc/n2L7EZdvw=; b=v62vbgbH5GsgDHdsy6Mq/eI38ml3TRq1766MlrSGtB2sDTnXNAQ5xUvFKvw7Q2UI/N gN1fn5uM7HKCATQoQKfRzPCbHLcxcaKSEem4XCYkXFai/qLCKW3fDnRg5P+7ofBO+VHn Q6GBh8YueSuve4eYKE945PUXTSmy30z97r3mOxzsEemJW7+havxUGAeOsVsR8lO8QB/r wDCx675DOrE3iNOvAPzlX2xwwaVAklDMCCMz+NAhGCkj0oJX2jZ0+vlQ/fPhkQRf3X2T jySyXpR6vJNtd6fIXwIQWyCQtUyJG1ezeTEF9gyEEs0NRq0IijBubLVmt9n57IIJZCVf 9XvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=WZ/VqO0Y5Z2+nzfW9+St0EhhfoPl1nEoc/n2L7EZdvw=; b=gbq/eeFpn3E27NX0S2YHx8/sMWmG7yhwMkQ5089QQVP3heqfef4Xhizv3UZHjAiP09 h4ZFiqlTwXI/+qVuB5iZP3qOnvgrsKU5ZPLSrcGWm80gBUvQi185E6MzZKovjWDIo3gl 6jwhDzrpavXlMapJAvQgRpGUuKOJWl2uhE4453URt5Q1KTRDm3NrLoIEck0h3GpeoAll M2SmxNQVjIYKY2LoeK6HNGHL0+V8Sl32C1w6w+wyjRWv0wHFj3CsqMYMYzImXYNNpVOL vSwiUi/2nbwM1KTADzT0m3R9J7JePPft2odxaJoQyB9RJuXuZbjTVPaq3zr5f5YMTIgd BHvg== X-Gm-Message-State: AOUpUlFGK6KWZaD2AGcl3qowPJmizLvYaUPQ8uJ35np6tTLLxYU+pGzj 3OmKtxWPDK0jBMYNKXvVhNah6w== X-Received: by 2002:a63:8c0b:: with SMTP id m11-v6mr18581423pgd.372.1533001773137; Mon, 30 Jul 2018 18:49:33 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id z10-v6sm17387799pfh.83.2018.07.30.18.49.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Jul 2018 18:49:32 -0700 (PDT) Date: Mon, 30 Jul 2018 18:49:31 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Roman Gushchin cc: linux-mm@kvack.org, Michal Hocko , Johannes Weiner , Tetsuo Handa , Tejun Heo , kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] introduce memory.oom.group In-Reply-To: <20180730180100.25079-1-guro@fb.com> Message-ID: References: <20180730180100.25079-1-guro@fb.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jul 2018, Roman Gushchin wrote: > This is a tiny implementation of cgroup-aware OOM killer, > which adds an ability to kill a cgroup as a single unit > and so guarantee the integrity of the workload. > > Although it has only a limited functionality in comparison > to what now resides in the mm tree (it doesn't change > the victim task selection algorithm, doesn't look > at memory stas on cgroup level, etc), it's also much > simpler and more straightforward. So, hopefully, we can > avoid having long debates here, as we had with the full > implementation. > > As it doesn't prevent any futher development, > and implements an useful and complete feature, > it looks as a sane way forward. > > This patchset is against Linus's tree to avoid conflicts > with the cgroup-aware OOM killer patchset in the mm tree. > > Two first patches are already in the mm tree. > The first one ("mm: introduce mem_cgroup_put() helper") > is totally fine, and the second's commit message has to be > changed to reflect that it's not a part of old patchset > anymore. > What's the plan with the cgroup aware oom killer? It has been sitting in the -mm tree for ages with no clear path to being merged. Are you suggesting this patchset as a preliminary series so the cgroup aware oom killer should be removed from the -mm tree and this should be merged instead? If so, what is the plan going forward for the cgroup aware oom killer? Are you planning on reviewing the patchset to fix the cgroup aware oom killer at https://marc.info/?l=linux-kernel&m=153152325411865 which has been waiting for feedback since March?