Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4619797imm; Mon, 30 Jul 2018 19:09:53 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf+Kkb40NgLXqz1FhsT+LobklnihPKrv8YWYN38PvaH+jAKsK5+SEzmk4w340ofhJZGrL4a X-Received: by 2002:a17:902:8c88:: with SMTP id t8-v6mr12943659plo.117.1533002993914; Mon, 30 Jul 2018 19:09:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533002993; cv=none; d=google.com; s=arc-20160816; b=WNxkGpSXGMDujYEG5ljm3rtXJ2S5MBB8NabmV12efWwQVAjm2ZRt3W3O7rzcP1CBB3 teV7zvIRPDI1J+yPoLO0qOMAWPwNTgtSIQdibg+KjiyOzzjhBYKQzfePjFzQ8q2+yqdR Y8HxK/c0gxIovy/CsYDe7RzVcg+/R4sz0T7SEjuDBKWqgR0FhtAM7cNYYbYb0lr/cj9p sB/ssSrYsuNMhLYVCr5Wxmep8WbmRi2PMrIlrL3tazJh1hZBuwys00iBhzhR7ztHun4D OSzWouDexOd8WI2wIjnvU5IGeemxGGIeTFGk0L8hLAtsfMg0U40BuBOS+40Q1l4T9jck sEoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=FBu7pvEBYbS2k2YbT5ep9zU7YkMDWOFgXVWyWZJIdtk=; b=uBr5/K7vgLbIE94A41oUGtpWvxIaU1Y2hZp2fJBLl7VCzLiaRZSPHVRyC8hIJHfaLq S9ziUEU/5RMU53rqypxnMW7tPAtnpHV/lMc+9RZS0a1ZM5sHP7zeZX0ayJjkYl7sr6PW p6Fw+UpuWAErI9CZM5F490vaklFzWajgQtGCHnhc+hc714/ATC5vY9JHLpAp4v8AUfno 9bXCmk+BNmCWVh0h43fz69IhaOJkjW1ciLHtCNtDx55/QV2a+vFIh4Lh5QV6M0tbdAdQ /831Xu6r1JhbD0MKAeBnlbgwaiiZ0BlnUxxPxEuXulketT1QlQFQMGKBSsqYB+SByZKi Zmew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=HVUQnN7G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12-v6si12270160pgh.264.2018.07.30.19.09.39; Mon, 30 Jul 2018 19:09:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=HVUQnN7G; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731699AbeGaDqh (ORCPT + 99 others); Mon, 30 Jul 2018 23:46:37 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:53464 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729104AbeGaDqh (ORCPT ); Mon, 30 Jul 2018 23:46:37 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6V2446v137427; Tue, 31 Jul 2018 02:08:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=FBu7pvEBYbS2k2YbT5ep9zU7YkMDWOFgXVWyWZJIdtk=; b=HVUQnN7GZI8ZDKIa8ptJswUzMYB6v5y2EhM/wwHRjrBPNkAu07nC/ZuW4NVpxDFLT6tX AVuq97vDmcuUXXa52PDparleBBmXHb79H0JjB4w5//lIFtV273853ptjP6TJ44ybi64e /53fwBz/4v7IgQtb6a75JrlcAaLt2fU8amaSF3FNzaJlNbMjDx+Azyd2m2w1vDWKTw/D IBcFMetIVigy2sV05RiOdNn2ErolGVteEg/qFKB/GJ2fxbcT/6tCuBmg9LEKSeIqax7r C2uabSHv2ftjNKZzTlEbUpZRUmDeIbWAMuUc2qpZstAQJbfV/9iGl0Q0kHZLwvtLwj6h dQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2kge0cy1m4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Jul 2018 02:08:32 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w6V28UUa022202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Jul 2018 02:08:30 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6V28Shq024605; Tue, 31 Jul 2018 02:08:29 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 Jul 2018 19:08:28 -0700 To: Anton Vasilyev Cc: "James E.J. Bottomley" , Adam Radford , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] scsi: 3ware: fix return 0 on the error path of probe From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180727135157.13051-1-vasilyev@ispras.ru> Date: Mon, 30 Jul 2018 22:08:26 -0400 In-Reply-To: <20180727135157.13051-1-vasilyev@ispras.ru> (Anton Vasilyev's message of "Fri, 27 Jul 2018 16:51:57 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8970 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=681 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807310021 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anton, > tw_probe() returns 0 in case of fail of tw_initialize_device_extension(), > pci_resource_start() or tw_reset_sequence() and releases resources. > twl_probe() returns 0 in case of fail of twl_initialize_device_extension(), > pci_iomap() and twl_reset_sequence(). > twa_probe() returns 0 in case of fail of tw_initialize_device_extension(), > ioremap() and twa_reset_sequence(). Applied to 4.19/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering