Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC] blk-mq: clean up the hctx restart
To:     Ming Lei <ming.lei@redhat.com>
Cc:     axboe@kernel.dk, bart.vanassche@wdc.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1533009735-2221-1-git-send-email-jianchao.w.wang@oracle.com>
 <20180731045805.GE15701@ming.t460p>
From:   "jianchao.wang" <jianchao.w.wang@oracle.com>
Message-ID: <8a3383e6-2926-6858-d8f2-671f3cb9e460@oracle.com>
Date:   Tue, 31 Jul 2018 13:19:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180731045805.GE15701@ming.t460p>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ming

On 07/31/2018 12:58 PM, Ming Lei wrote:
> On Tue, Jul 31, 2018 at 12:02:15PM +0800, Jianchao Wang wrote:
>> Currently, we will always set SCHED_RESTART whenever there are
>> requests in hctx->dispatch, then when request is completed and
>> freed the hctx queues will be restarted to avoid IO hang. This
>> is unnecessary most of time. Especially when there are lots of
>> LUNs attached to one host, the RR restart loop could be very
>> expensive.
> 
> The big RR restart loop has been killed in the following commit:
> 
> commit 97889f9ac24f8d2fc8e703ea7f80c162bab10d4d
> Author: Ming Lei <ming.lei@redhat.com>
> Date:   Mon Jun 25 19:31:48 2018 +0800
> 
>     blk-mq: remove synchronize_rcu() from blk_mq_del_queue_tag_set()
> 
> 

Oh, sorry, I didn't look into this patch due to its title when iterated the mail list,
therefore I didn't realize the RR restart loop has already been killed. :)

The RR restart loop could ensure the fairness of sharing some LLDD resource,
not just avoid IO hung. Is it OK to kill it totally ?

Thanks
Jianchao