Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180729193646.201721-1-toddpoynor@gmail.com> <20180729193646.201721-2-toddpoynor@gmail.com>
 <CAE_wzQ-VmW=X-HEFj4PouxUcH6jKqHR_XXhXfrQmx_-CPE_tWQ@mail.gmail.com>
In-Reply-To: <CAE_wzQ-VmW=X-HEFj4PouxUcH6jKqHR_XXhXfrQmx_-CPE_tWQ@mail.gmail.com>
From:   Todd Poynor <toddpoynor@google.com>
Date:   Mon, 30 Jul 2018 23:29:37 -0700
Message-ID: <CAAW3YpYQcn-=eU+UTst1u7oKpW2k8R9Yvd-8i91hCaRGySUHiQ@mail.gmail.com>
Subject: Re: [PATCH 01/13] staging: gasket: core: hold reference to pci_dev
 while used
To:     Dmitry Torokhov <dtor@chromium.org>
Cc:     "toddpoynor@gmail.com" <toddpoynor@gmail.com>,
        Rob Springer <rspringer@google.com>,
        John Joseph <jnjoseph@google.com>, benchan@chromium.org,
        Greg KH <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 30, 2018 at 11:19 PM Dmitry Torokhov <dtor@chromium.org> wrote:
>
> On Sun, Jul 29, 2018 at 12:37 PM Todd Poynor <toddpoynor@gmail.com> wrote:
> >
> > From: Todd Poynor <toddpoynor@google.com>
> >
> > Hold a reference on the struct pci_dev while a pointer to it is held in
> > the gasket data structures.
> >
> > Signed-off-by: Todd Poynor <toddpoynor@google.com>
> > ---
> >  drivers/staging/gasket/gasket_core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> > index 2b484d067c38a..b832a4f529f27 100644
> > --- a/drivers/staging/gasket/gasket_core.c
> > +++ b/drivers/staging/gasket/gasket_core.c
> > @@ -488,6 +488,7 @@ static void gasket_free_dev(struct gasket_dev *gasket_dev)
> >         internal_desc->devs[gasket_dev->dev_idx] = NULL;
> >         mutex_unlock(&internal_desc->mutex);
> >         put_device(gasket_dev->dev);
> > +       pci_dev_put(gasket_dev->pci_dev);
>
> gasket_free_dev() is called only from driver PCI probe and remove
> function. I can assure you that that pci_dev structure is not going
> anywhere, there is no need to take this additional reference.

WIll fix, thanks.

>
> Thanks,
> Dmitry