Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <15f7c81085d98709dc38fa6d14694f893d6101e6.camel@perches.com>
References: <CAFGhKbzXiAx3iaveOQhXCseH2kg1U=j-sp0B9jNSF2wPUjDtFg@mail.gmail.com>
 <14f411527d551411defdd73a2507a13b7f07e789.camel@perches.com>
 <CAFGhKby698K852CWEh3zF_cqoumCgnv7OXLXrN2L9s-E4knBnA@mail.gmail.com> <15f7c81085d98709dc38fa6d14694f893d6101e6.camel@perches.com>
From:   Charlemagne Lasse <charlemagnelasse@gmail.com>
Date:   Tue, 31 Jul 2018 08:44:37 +0200
Message-ID: <CAFGhKbzHmYX+fagyzsV2_PstGATfMuu=h8j40Mznwac393MHBA@mail.gmail.com>
Subject: Re: checkpatch: SPDX integration breaks --root
To:     Joe Perches <joe@perches.com>
Cc:     Rob Herring <robh@kernel.org>, Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> OK. How about:
>
> though this might not work on a path with spaces
> or some such...
>
> ---
>  scripts/checkpatch.pl | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index f25f708cd2a7..afb9fb27908c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -852,9 +852,10 @@ sub is_maintained_obsolete {
>  sub is_SPDX_License_valid {
>         my ($license) = @_;
>
> -       return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py"));
> +       return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/.git"));
>
> -       my $status = `echo "$license" | python $root/scripts/spdxcheck.py -`;
> +       my $root_path = abs_path($root);
> +       my $status = `cd $root_path; echo "$license" | python scripts/spdxcheck.py -`;
>         return 0 if ($status ne "");
>         return 1;
>  }

Thanks, works at least for me. Maybe use

cd "$root_path"

to get it working with paths that include spaces.

Tested-by: Charlemagne Lasse <charlemagnelasse@gmail.com>