Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4828734imm; Tue, 31 Jul 2018 00:22:56 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeCtztaqC0ETvK+gKQvUIJTp/pXWQnKvzlVxeu8ocNwqIMfcEoHBvTjaMND8s+htOzgYjEh X-Received: by 2002:a63:5106:: with SMTP id f6-v6mr18771517pgb.95.1533021776699; Tue, 31 Jul 2018 00:22:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533021776; cv=none; d=google.com; s=arc-20160816; b=NiTjWq80+WAZqGfCzuvKt9WFjam0l6jBL22+4/h94vQIaJkUdM+kmPlkeCtva5XGLT 6H/eG9P3JwXVWdS7RLaiSEXKV9DRgY0/wSKFJVpqGyG2CkSfRwQct26LyvnZ0uTU3ncj 5kZN9LuoCzOh4kn+KCrSjc+BaAAVUW1CMX/jMPpryXFfe8CWKWGRABrqTj2oTTrB8PDx bn2YBdoTPRdxJKQSoP8JKAXgn6hP4uVg/9BST95bFJRYX/Xib/+wargLMtVn3RzbWJo9 /bfLd6TJs2Vo4fqUojpAJjvb/KETJla0bemxLNZmdqouAlFXHWPKz7f5oIEOvCwvtrmK dWMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=kUTuV5uWnask2KXhgxephnF2+9GZJ6IhjJkPxObfjtk=; b=dtgpw2jvXzXQlpJHKPM07cHi8ojhUSfVn/s0HJNYnsIvdvxwN4OtPvXsEQY6RAM5MP 6y7OgKt/HtkrWlbDZSlReWK7Mw7jS77KKnwZBBdrKGgcl/NeVvbOxppVGZwASunvPX2f H0VrNOqLnNNhw4yHwn7L+OYPH3ljYSqzCbl9a0WffxS3D14x+XRuuHwjW/kgppHUq4MA Co/4OQbSgH16o0lgz/ZuXtMJ3LIj9nTD0I5gJiXAkvfm6G4Gth//5Hh+rgn6DhFOWhd4 cAt/0yDBuDv1eUlmv07KFkFFVrPvqJchs2ou+i5wxyNcF1UzjD52WqH8vPY1WM5UIbSa 9neQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=oqphSa9q; dkim=pass header.i=@codeaurora.org header.s=default header.b=l7l6RvJf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7-v6si11502302plo.186.2018.07.31.00.22.42; Tue, 31 Jul 2018 00:22:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=oqphSa9q; dkim=pass header.i=@codeaurora.org header.s=default header.b=l7l6RvJf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731981AbeGaJAs (ORCPT + 99 others); Tue, 31 Jul 2018 05:00:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57858 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727569AbeGaJAs (ORCPT ); Tue, 31 Jul 2018 05:00:48 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D79D860376; Tue, 31 Jul 2018 07:21:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533021712; bh=hpL0ALPXuc3s7A/FzbB7qpFmcXbtV1DFJp6dgoK5dQM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=oqphSa9qWMW5mtz7nElLdGpHWxswAxH6zYLEYggyKoTpBktDOEoyEvicexJbE3Ckj u2YFpkPPzRRFj7X623RfgHlXGYGBvXwO+CbvCeO3utkAB9ln3Q3cDa3VoB80ZJfL8l uyLRnZ7rFZSZ8ygOGOXChzWWiGAGI9YnAdtfGQck= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B242D60376; Tue, 31 Jul 2018 07:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533021712; bh=hpL0ALPXuc3s7A/FzbB7qpFmcXbtV1DFJp6dgoK5dQM=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=l7l6RvJfTc1/tNm0+v2pjWJ9A1kz1/NmNBSyK/zc6sjhV2yYaKwaVhruSzpppjP6U DYotkjjd2zEODducyTw1LkxoPhNnBoSJHfg3T4qUN946ii81bpPs7kV5APh1nHJImn 5+0hHzyQNEAQrR7wJxhFeZejC1/ilv8zIf07/GHg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B242D60376 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] hostap: hide unused procfs helpers From: Kalle Valo In-Reply-To: <20180713070317.6724-1-yuehaibing@huawei.com> References: <20180713070317.6724-1-yuehaibing@huawei.com> To: YueHaibing Cc: , , , , , YueHaibing User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180731072152.D79D860376@smtp.codeaurora.org> Date: Tue, 31 Jul 2018 07:21:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing wrote: > When CONFIG_PROC_FS isn't set, gcc warning this: > > drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: ‘prism2_registers_proc_show’ defined but not used [-Wunused-function] > static int prism2_registers_proc_show(struct seq_file *m, void *v) > > drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: ‘prism2_debug_proc_show’ defined but not used [-Wunused-function] > static int prism2_debug_proc_show(struct seq_file *m, void *v) > ^ > drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: ‘prism2_stats_proc_show’ defined but not used [-Wunused-function] > static int prism2_stats_proc_show(struct seq_file *m, void *v) > ^ > drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: ‘prism2_crypt_proc_show’ defined but not used [-Wunused-function] > static int prism2_crypt_proc_show(struct seq_file *m, void *v) > ^ > > fix this by adding #ifdef around them. > hfa384x_read_reg is only used by prism2_registers_proc_show,so move it > into #ifdef. > > Signed-off-by: YueHaibing Patch applied to wireless-drivers-next.git, thanks. 6ade689711ee hostap: hide unused procfs helpers -- https://patchwork.kernel.org/patch/10522651/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches