Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4832338imm; Tue, 31 Jul 2018 00:28:07 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf5KG/wOL8+kEq9hxovPyRHrdOsrZw90LUD+coo0kNbji80TBeFsc+yRK8CtyKdcY6PM9T5 X-Received: by 2002:a62:87ce:: with SMTP id i197-v6mr21122845pfe.62.1533022087471; Tue, 31 Jul 2018 00:28:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533022087; cv=none; d=google.com; s=arc-20160816; b=Qdkr4mTn/eV3Ry2Cy/WNOOnNRDShovhoVAPi5uNJT+xJmbOmFUJkmqgiKet6JHH4L7 5lgTfQvLvBox8TPtMnnItaN4emanFyGA6Yy5O2PNG6MO9TK06rgrdI7Kx6dDU31yxzua Vch1U3GBte3EoHWMFHh0teZv1tsDnoKoqDDuoaStf+aSSdX8I+eURsoq4cSGs82uI1// HtAAQmObeYGHJz587lPO8fHMmkemypG37j7z/+0DFTShr0Nd1v6f2whqOeaGgacLI2HH qEDQeUtaqcvcWrCLeZ4UI7477ZtboBIZq+xBVk+kwbtozQYqXc+jL3eYdHO6sqt4xLEq C0Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=glsrnPJVJoZqjTz8ufFQSVH3SfNAVQLN7yb+qETEq70=; b=ITxvDJBwi6onEfcjCIqE7pdqiGMq5sVH740j3jMOEofI5T9BcssLziN9D7Bl4T8FUu HOCWrfDaLOy6FbsiXJYOcxv1rQPDDtEcq/sUYZP+MeC7Z0d8P8mHrnQM3pPJ0AnrCeG5 F3rfdBPveqW2tq3QSfHBRJSwIFxI2k1hB5ZSeVvUTHxkzoIj0scCy8VHSImM+RAUBRpB Jx/PlzWvMb0GpwvzJkb+ruhadYyYV+1AjXJs8AIUseKh7u/ECXG08wlKg3QqHnVICLiI smUgjJue48xeJu+L+7wF0tr8FU8ADMoMlDRs0sx3uuLx0fsiRuJfXYUtYqI8RurAPams ugWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=f55Hryxj; dkim=pass header.i=@codeaurora.org header.s=default header.b=VBHZSwVy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1-v6si13978490pfl.215.2018.07.31.00.27.53; Tue, 31 Jul 2018 00:28:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=f55Hryxj; dkim=pass header.i=@codeaurora.org header.s=default header.b=VBHZSwVy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731697AbeGaJGA (ORCPT + 99 others); Tue, 31 Jul 2018 05:06:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34212 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727569AbeGaJGA (ORCPT ); Tue, 31 Jul 2018 05:06:00 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6141960708; Tue, 31 Jul 2018 07:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533022023; bh=0FfgnG9WoYM828o8JXWnJIU7oWBDbL3AT1YkpDmHBC0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=f55Hryxjdyvoo2AFTJUGj9xM/f7pq/32C2liqlN09dy02xPl4SZJyRtE/eHFW6AiS 41E7djKdkzruzVGdwrBRWmV9s+vlA0Zj7PwCatV1QsORg7tYZ+WAUJHncFhDKHxKud f6S+tYbB9RlCsQIOc3ksR7YtODE3V/3JcPPqjJk4= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id ED03A60376; Tue, 31 Jul 2018 07:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533022023; bh=0FfgnG9WoYM828o8JXWnJIU7oWBDbL3AT1YkpDmHBC0=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=VBHZSwVygdBqlJzn8io3Pqzfxgthu9lH9J592EJ3SRIr2ZW7gEKvq1mPZS6zsMoWj WrC+F1lRfyJde2PVpyf7OXekK4ezcrCsxyHd7EJtZNe0M+TTGW88f0WL20i2P0tOyd 7wSzqWXtwA31/LCfHdmItoKi7jdx1vSj6rY6A5HE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ED03A60376 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtl818x: Replace mdelay() with msleep() in rtl8225se_rf_init From: Kalle Valo In-Reply-To: <20180727085045.3949-1-baijiaju1990@gmail.com> References: <20180727085045.3949-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180731072703.6141960708@smtp.codeaurora.org> Date: Tue, 31 Jul 2018 07:27:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jia-Ju Bai wrote: > rtl8225se_rf_init() is never called in atomic context. > It calls mdelay() to busily wait, which is not necessary. > mdelay() can be replaced with msleep(). > This patch only replaces the mdelay() that has >20ms time to wait. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai Patch applied to wireless-drivers-next.git, thanks. 622e938240db rtl818x: Replace mdelay() with msleep() in rtl8225se_rf_init -- https://patchwork.kernel.org/patch/10546749/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches