Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4849669imm; Tue, 31 Jul 2018 00:52:05 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdN3YEAk8A/ckVelrW15J3rDA/7TGqs/++zl8Akh62xq50aWO6p5XLAyD1amgbjHMFRtOwy X-Received: by 2002:a17:902:6b4c:: with SMTP id g12-v6mr19192192plt.159.1533023525703; Tue, 31 Jul 2018 00:52:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533023525; cv=none; d=google.com; s=arc-20160816; b=OIPiW7+tlFbyWRaggSxIFXN/EBe1ok1sNa/yHixAY3wldbqLRZq8Y49W7HXEJjKBtk eaFhCymZDLxCnZXcEUwJ7ySxF9noftJJxvhnX7ev+fUJBrXW5z0qBKh4T1qRa+tQihRn 8cFRPKawD0md0EKcdWzI8GWEWLqGjShuwxty6cwgY1YbG21Uc7IWTzVqI5LLhJeBxvlK IDCNw2nvnbGMVgzGwa4/6UkWNuIAj9UXYFQ65Z8cybCcHTvWSXdPmrRSRv/G7h9/Ufqn dRwOSj5oGSMobEFG92jXmLXorMrYRf3ZM2KtMFHoI4Fp+184ZzkIsLvKB7k5URpQ+SBC N+cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=Pd8qKfgbOW8SE1G+Cti3IlDv36vz7ZmZKcg0T1k5Kow=; b=ovvsxcLs06uqa0aPbyzt2bKS6oDzbbmzFVyhxGgB2SBZkyC+si4NGNis3mDZTwfdbI MP2tRnt3ea96Xing70KLIJ7HETuxKSE3qLtxnxkfXNe8n2lV+F8lJUG+jeHZwqeRDOOX piIGn+/M2Nxyk5Rw8fJNtNc75EuXcaTzwX6DMa+C7nYjyGOeFy+04un3oGeTyau/CoOy Duln1aZ1ILDVUdnFlduUmWb/Xl7vBvh9hcUxFAgTLvz8IWH0NREtag4AhYeBEFp9uceM z0JtOIVaNm32DdHo5AJgsYJA5DzwQHTeZ2vFj+OBO50LpynxVJkjNY8j8c0uEtnSGiLn GcEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ed+qS9x2; dkim=pass header.i=@codeaurora.org header.s=default header.b=EykpxV0l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k125-v6si12510986pgk.315.2018.07.31.00.51.51; Tue, 31 Jul 2018 00:52:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Ed+qS9x2; dkim=pass header.i=@codeaurora.org header.s=default header.b=EykpxV0l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729622AbeGaJ33 (ORCPT + 99 others); Tue, 31 Jul 2018 05:29:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43442 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbeGaJ33 (ORCPT ); Tue, 31 Jul 2018 05:29:29 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1FA2D6071C; Tue, 31 Jul 2018 07:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533023427; bh=ztqX2pxvTJxwEZgFmgMRtAm6Rj/xEaVPnoQq3Xs+HC8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ed+qS9x20bct/RMqDHLLMGf0YUjoksBHYJB4Lb8RCOg3fqtG6DI8rOgX/aLYyNpsX CCIUG7TnGKUXACc5STd/G3ZYNgVqF9OtxcjAMe3P2YIvMk3saCuloD8fQvK0e8G3dC vU7WO74hxmLysmyZYwCxpuJu3xU1nzfC40+6BA94= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,MISSING_DATE,MISSING_MID,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5B028606DD; Tue, 31 Jul 2018 07:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533023426; bh=ztqX2pxvTJxwEZgFmgMRtAm6Rj/xEaVPnoQq3Xs+HC8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=EykpxV0lgxV9u7IpiMaJq+nT816SV+PJdCBrkGjRXhhOSDSLHr/xiYCZNXmAS9TLt elgCeiEIPIxSahlrYOhjxGuo/rSZ9/MT+rNhD2q0V46bjf41AoU2/iEP9vdmyZXWEr 4FzCXHLq7NgEKlQ9tBgTeJoruoLaGT5c5ubePW/Y= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5B028606DD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] net: wireless: ath6kl: Replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init() From: Kalle Valo In-Reply-To: <20180727084318.3345-1-baijiaju1990@gmail.com> References: <20180727084318.3345-1-baijiaju1990@gmail.com> To: Jia-Ju Bai Cc: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20180731075027.1FA2D6071C@smtp.codeaurora.org> Date: Tue, 31 Jul 2018 07:50:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jia-Ju Bai wrote: > ath6kl_bmi_init() is never called in atomic context. > It calls kzalloc() with GFP_ATOMIC, which is not necessary. > GFP_ATOMIC can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself. > > Signed-off-by: Jia-Ju Bai > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. bfc55fe65987 ath6kl: replace GFP_ATOMIC with GFP_KERNEL in ath6kl_bmi_init() -- https://patchwork.kernel.org/patch/10546741/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches