Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] arm64, kaslr: export offset in VMCOREINFO ELF notes
To:     Bhupesh Sharma <bhsharma@redhat.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kexec@lists.infradead.org, bhupesh.linux@gmail.com,
        takahiro.akashi@linaro.org, catalin.marinas@arm.com,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Will Deacon <will.deacon@arm.com>,
        Mark Rutland <mark.rutland@arm.com>
References: <1532931883-16132-1-git-send-email-bhsharma@redhat.com>
From:   James Morse <james.morse@arm.com>
Message-ID: <303e32f7-ff47-ea9b-d5a0-45a22e44d0a9@arm.com>
Date:   Tue, 31 Jul 2018 10:19:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1532931883-16132-1-git-send-email-bhsharma@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Bhupesh,

On 30/07/18 07:24, Bhupesh Sharma wrote:
> Include KASLR offset in arm64 VMCOREINFO ELF notes to assist in
> debugging. vmcore parsing in user-space already expects this value in
> the notes and we are providing it for portability of those existing
> tools with x86.
> 
> Ideally we would like core code to do this (so that way this
> information won't be missed when an architecture adds KASLR support),
> but mips has CONFIG_RANDOMIZE_BASE, and doesn't provide kaslr_offset(),
> so I am not sure if this is needed for mips (and other such similar arch
> cases in future). So, lets keep this architecture specific for now.

(heh, I assumed you would rewrite my train-of-thought, but I guess this works!)


> As an example of a user-space use-case, consider the
> makedumpfile user-space utility which will need fixup to use this
> KASLR offset to work with cases where we need to find a way to
> translate symbol address from vmlinux to kernel run time address
> in case of KASLR boot on arm64.

Acked-by: James Morse <james.morse@arm.com>

If we want to send this to stable, it looks like it should have been part of the
KASLR series, f80fb3a3d5084 ("arm64: add support for kernel ASLR") was merged
for v4.6.
CC: <stable@vger.kernel.org> # 4.6.x


Thanks,

James


> diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
> index f62effc6e064..028df356a5fd 100644
> --- a/arch/arm64/kernel/machine_kexec.c
> +++ b/arch/arm64/kernel/machine_kexec.c
> @@ -360,4 +360,5 @@ void arch_crash_save_vmcoreinfo(void)
>  						kimage_voffset);
>  	vmcoreinfo_append_str("NUMBER(PHYS_OFFSET)=0x%llx\n",
>  						PHYS_OFFSET);
> +	vmcoreinfo_append_str("KERNELOFFSET=%lx\n", kaslr_offset());
>  }
>