Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263440AbTIWV2P (ORCPT ); Tue, 23 Sep 2003 17:28:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263441AbTIWV2P (ORCPT ); Tue, 23 Sep 2003 17:28:15 -0400 Received: from fw.osdl.org ([65.172.181.6]:40881 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S263440AbTIWV2O (ORCPT ); Tue, 23 Sep 2003 17:28:14 -0400 Date: Tue, 23 Sep 2003 14:28:12 -0700 (PDT) From: Linus Torvalds To: Deepak Saxena cc: linux-kernel@vger.kernel.org, Subject: Re: [PATCH] Fix %x parsing in vsscanf() In-Reply-To: <20030923212207.GA25234@xanadu.az.mvista.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 717 Lines: 20 On Tue, 23 Sep 2003, Deepak Saxena wrote: > > Another option is to put the check in simple_strtoul() and > simple_strtoull() if that is preferred. I like this better b/c > we only have the check once. I'd much rather fix strtoul[l](). In fact, strtoul[l]() _already_ accepts the "0x" prefix - but it only does so if the "base" parameter is 0. Fixing strtoul[l] should fix vsscanf() automatically, no? So I don't see the "have the check only once" argument. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/