Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5240437imm; Tue, 31 Jul 2018 07:45:44 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcviGLd22pzifdLlbfHlgfQ95SRTb4wnmAlgJ/C6q1+EBzpyaF7DEQYCquFlp3kTKhFmSOD X-Received: by 2002:a63:455c:: with SMTP id u28-v6mr20877152pgk.210.1533048344513; Tue, 31 Jul 2018 07:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533048344; cv=none; d=google.com; s=arc-20160816; b=qk7LCJr/B7R12OWHZXQwMK+iaGL1hIWd0TX39VQMytKkwNa/EdNloI42Arxiya6ftZ kG00JsC/tepnanHrhFKF4OfeD08V0Ia57tMePaDMxYhQk3q773qY95TdzyTmVasO2o3g hXG6+LYuuf7JMEmF0PBQiE+iA4kx8BRfKe3MNepIO06FtBSVl31a24oeLCjmwwVSZK+d 3dIs3VjsAUmhm4MTKPiWyCEMQE1vA0GKibEl6gzwiNVQuP7eJEfZjRuKTa+HywHNqo7a JUKzJ8POrxxJuTH3HRqyqRnLyn3DM808o06SpsWzUI4htXFE8zBMnYXz9OLE4CbWUXPW DpwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:mime-version:dkim-signature:arc-authentication-results; bh=t3HqzqKSoqb/3plGFTWy3IMh6yx9tOQfD9ADyQm+QJY=; b=nKhM9Vy5qauJhxsbYYfrxGyljiw9mrt2hN9ic8y79VNC3QQ9zQe25OlcQwU3x06hlg Wtv7JrDpnIjCujy8V5jCgVhIQQAwX1hKtbxh+H1Z5ag9hNqjH8hu11voaOk9IkzazdvY zrwFSknls274AGE+EKREUfF4tH6TpMNYFzQwn6Z3VYntsftADa6yeVLxH3S47+crjD5y YJLwJUFCS++Cv9cVEsq6qJA0e5MTuqkGwAUYBigEKxY1IVmFvJp8jw+ORhjlfEzJt9Qt bmROGkUZ+uof/sy3xupR8G2swRrHlV7CY4E3VdkKFKw6cSgxp27MqiXnMVZ//b3NepAB meuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=lmU9gdIf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8-v6si14615770pgr.260.2018.07.31.07.45.30; Tue, 31 Jul 2018 07:45:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=lmU9gdIf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732505AbeGaQZI (ORCPT + 99 others); Tue, 31 Jul 2018 12:25:08 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:54208 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732402AbeGaQZI (ORCPT ); Tue, 31 Jul 2018 12:25:08 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6VE90uA046868 for ; Tue, 31 Jul 2018 14:44:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : references : from : date : message-id : subject : to : cc : content-type; s=corp-2018-07-02; bh=t3HqzqKSoqb/3plGFTWy3IMh6yx9tOQfD9ADyQm+QJY=; b=lmU9gdIfcyyTcvguWYANVWMOWetfhwgtBf8yi7abcQdU3twFYNGjGb/ux6+rW30D58hv Dh+BdUnJ0ahbx75BrGVMnkFsLKtSIGPC8KFuV65PFwh2cqQR0i+a1CO4cFwM888hy/Uk juar8sP0eOuT7V4zwt+eBhHaygJaQWLrJSiet3MxAVLBPoJHGErEZ03PRwshS3EFZU/2 +LB/8SAamRFXHIGSlz/wt8xlHSSF1p9CCKQCpuCkwdzdULYshvaqxzfSnrRCdkk73xuD hk7hPY37zV+y6X28UCTPRzXPcNcPhMdLodjQ3aalMg/O9bGGh/iw4bAys59UD8xImkth 3A== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2kgfwt1d6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 31 Jul 2018 14:44:28 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6VEiR4c012530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 31 Jul 2018 14:44:28 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w6VEiRaj014088 for ; Tue, 31 Jul 2018 14:44:27 GMT Received: from mail-oi0-f50.google.com (/209.85.218.50) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 31 Jul 2018 07:44:27 -0700 Received: by mail-oi0-f50.google.com with SMTP id q11-v6so28381505oic.12 for ; Tue, 31 Jul 2018 07:44:27 -0700 (PDT) X-Gm-Message-State: AOUpUlHnCV6/Zcd6rDSsbA8Lcn4nua0CGwcNjOvESaJMD+3zAf5DrpDF ceBBLBReVD/HLMxr18hdVXsqrY1BCTTEOiXmKPM= X-Received: by 2002:aca:3bc2:: with SMTP id i185-v6mr24442152oia.156.1533048267399; Tue, 31 Jul 2018 07:44:27 -0700 (PDT) MIME-Version: 1.0 References: <20180731124504.27582-1-osalvador@techadventures.net> <20180731144157.GA1499@techadventures.net> From: Pavel Tatashin Date: Tue, 31 Jul 2018 10:43:51 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: make __paginginit based on CONFIG_MEMORY_HOTPLUG To: osalvador@techadventures.net Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , kirill.shutemov@linux.intel.com, iamjoonsoo.kim@lge.com, Mel Gorman , Souptick Joarder , Linux Memory Management List , LKML , osalvador@suse.de Content-Type: text/plain; charset="UTF-8" X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8970 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=804 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807310137 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 10:43 AM Pavel Tatashin wrote: > > Hi Oscar, > > There is a simpler way. I will send it out in a bit. No need for your first function, only setup_usemap() needs to be changed to __ref. I meant first patch not function :) > > Pavel > On Tue, Jul 31, 2018 at 10:42 AM Oscar Salvador wrote: > > > > On Tue, Jul 31, 2018 at 08:49:11AM -0400, Pavel Tatashin wrote: > > > Hi Oscar, > > > > > > Have you looked into replacing __paginginit via __meminit ? What is > > > the reason to keep both? > > Hi Pavel, > > > > Actually, thinking a bit more about this, it might make sense to remove > > __paginginit altogether and keep only __meminit. > > Looking at the original commit, I think that it was put as a way to abstract it. > > > > After the patchset [1] has been applied, only two functions marked as __paginginit > > remain, so it will be less hassle to replace that with __meminit. > > > > I will send a v2 tomorrow to be applied on top of [1]. > > > > [1] https://patchwork.kernel.org/patch/10548861/ > > > > Thanks > > -- > > Oscar Salvador > > SUSE L3 > >