Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5292767imm; Tue, 31 Jul 2018 08:33:14 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdzb9UHeP7NO+fm7TNk69+2dxP10c605P3CKWqXspK1S5mUk8RfWAHN0U3a88LZM19Yf1bL X-Received: by 2002:a63:5a13:: with SMTP id o19-v6mr20860933pgb.195.1533051194913; Tue, 31 Jul 2018 08:33:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533051194; cv=none; d=google.com; s=arc-20160816; b=RRCkDvTSCVBBmB5P1fo09T5Ry5XNg/rzMvOI+fajLqFr57QuLpN4A8WKzqnc2QP7O+ gDIlbV4+LefYeVbciXltOd3JlNdjLtnd9aqhNffpUDWxfQlS58p7QkNBbg0ow8vhxgke NtVwRFjzDic0RMRFlV/TV3I/ckVYdjl0KgSls12nhqMsbZ9/IDoG/M2hoJpQ8awFwHL7 JuUrTVfUNar7kumpQ9eyc7PP1Cb5o1pghW8qFzkAJ21CYRyTtki69EQny4By9/HdjSsF 7hrfqSKjQs9iduQevAnDwZIjPJ3AVxsnZ8hIML2ny85xOIenaGwudt9O+CLM42L5v52l NIPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=4GN4EUqOSx5ccCv8HrhOY+IAPKWnZLAB1N2TfSdzhMw=; b=xhY/h5tLh802pjd/TsFwiS72Kx6Hy6ObwmB8Y54H04AhDbMMMTZJEZLMj97ABXaodv 46hNpwXzBxfpAevdDl655j4d/aUJxwNR+mE3gqgXPR5XzVydsnhgna/7ydUqZPLgSAVm s2XXRBJHffa4gzsuTKzqxznYNBhJA4mKa72WpO0n444o/pjz/En2xxfMMVwWpz9rletz B7S29yN0qPvsImYUv0B/37Z2gWta4xsqIJiKhoNchuxqg7nS6dUJbz5tKpVhJaIARYVU Q6Qqijzx6GIFRq4WxgkKPukMxA0HytEq/j3a8rKRNhT294u4ARU3PPUnUfK/6QcynNl/ KFPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a14-v6si14498091pfl.349.2018.07.31.08.32.59; Tue, 31 Jul 2018 08:33:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732407AbeGaRMr (ORCPT + 99 others); Tue, 31 Jul 2018 13:12:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:37126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732269AbeGaRMr (ORCPT ); Tue, 31 Jul 2018 13:12:47 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 780F620841; Tue, 31 Jul 2018 15:31:55 +0000 (UTC) Date: Tue, 31 Jul 2018 11:31:53 -0400 From: Steven Rostedt To: Kees Cook Cc: Zubin Mithra , LKML , Guenter Roeck Subject: Re: [PATCH v2] tracefs: Annotate tracefs_ops with __ro_after_init Message-ID: <20180731113153.67471c20@gandalf.local.home> In-Reply-To: References: <20180725171901.4468-1-zsm@chromium.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jul 2018 17:25:06 -0700 Kees Cook wrote: > On Wed, Jul 25, 2018 at 11:00 AM, Kees Cook wrote: > > On Wed, Jul 25, 2018 at 10:19 AM, Zubin Mithra wrote: > >> tracefs_ops is initialized inside tracefs_create_instance_dir and not > >> modified after. tracefs_create_instance_dir allows for initialization > >> only once, and is called from create_trace_instances(marked __init), > >> which is called from tracer_init_tracefs(marked __init). Also, mark > >> tracefs_create_instance_dir as __init. > >> > >> Signed-off-by: Zubin Mithra > > > > Reviewed-by: Kees Cook > > Steve, do you have a tree for this or should we rope akpm in? :) > I'll pull it in. I'm currently working on a bunch of small patches for the merge window now anyway. Thanks! -- Steve