Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5462619imm; Tue, 31 Jul 2018 11:17:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe13zHhDST02dWd1K7coxpqahdGXJ8qVnkgWUOO9bpGapggo088r8ZmE9Xept13Sl0BzO/v X-Received: by 2002:a63:1e66:: with SMTP id p38-v6mr21310025pgm.376.1533061045919; Tue, 31 Jul 2018 11:17:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533061045; cv=none; d=google.com; s=arc-20160816; b=GTviXCZsesK8hfP9fDSfBFFQpYgBfzPW8KFJaTrqDKW/zctRv+M/maD/F6UNW7BYs/ MHKtMoNWutVc5Ztk294D5EShdM/I4aHpJF+LkhqBdNDrvhrFHsGE8Z+E5Iw+MoRWPmmS 8d5mbL680uNOJDk7uqDWc6bzzS4F0O2L5iRwv0CZ8qfyP8STQj4rqNNqF2L0KToba07o ldO84tqrDoD8CP3efOpvgQGR7as9h14snWQtGFqIf08xnhQCpWBQzAuGkR8VDdTh2Be4 IyNcPRQXRHFzNHKSZyKuOXwt+/ZN6gAgholiJA5ZUbnZ97vmE1j4kzJmcBbnNWWudb+B n/tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=YpI10Uogb87ABkln8vuCI7eyH7v3bXpzrZFA0sm1uKs=; b=Y8JqhabixXSRDQVg02eJG07C3Ka8KMakVmJ2qmeMcZ8BcF8++sDevErB/KiV+XjeK/ mwe0oHLCSz+AnztUSqYxRjMqfDyED9l5OiYR3KnbHTjCAHAVpfwE9BI9TuXLrmANdkus LtXFy61E3X2gJkQcbdQx1UZYzeWjbVBKSKuqBNIbBRH7TayDb3SqW8igzNIsONNTaqli VrCxb6vQTdmgUJGs9ApO0kCyeRkQTUi5WGdNEylXMs8cSCK/N8Y+8wThrNIaa7zdvoMt EVgAUlgjyUXCj+mgj0xQqj+mcqKoTZUYDGiDRL5T86pxVWYaC0LW/2GEFbw26M0B8k3q vRMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="PQe/8+Ri"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s17-v6si13263049plr.120.2018.07.31.11.16.53; Tue, 31 Jul 2018 11:17:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="PQe/8+Ri"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729725AbeGaT4s (ORCPT + 99 others); Tue, 31 Jul 2018 15:56:48 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:38954 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728140AbeGaT4r (ORCPT ); Tue, 31 Jul 2018 15:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpI10Uogb87ABkln8vuCI7eyH7v3bXpzrZFA0sm1uKs=; b=PQe/8+Ri9DwrbsAwBSEfzg7ny 7vBaLjttjdEptr3aOpsi7fVpNH+TFNHYq547fcmB5RqMP28/DUr/rDUhPK7Ck6T5M4y8EQWVL4WNB PMwSUOy/AzYjddbjKwUvBV6UvWnhczgnTfat8dQvQNj4SW7CvT0dfWSEviK1HyRoUR9Q6BJ55qutv Cu2Poxn4fu1qxs3+0ChQhIDYcJuEEeRf7NvvNemqCv2K7QaZQjp4HCZ+/yG9dz3jwxluMGMZZWbw+ kIVRrKIrQhD5CI5WhW6m13VG2ix9+4Av5AhbOLHBX2BlBwXJVjCG025GXs17JsP5uaBPWHrtclL5J dlubSZoRg==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fkZAs-0007T9-Os; Tue, 31 Jul 2018 18:15:10 +0000 Date: Tue, 31 Jul 2018 11:15:10 -0700 From: Matthew Wilcox To: "Martin K. Petersen" Cc: Mike Christie , linux-kernel@vger.kernel.org, "Nicholas A. Bellinger" , Bart Van Assche , Hannes Reinecke , Kees Cook , Varun Prakash , Sagi Grimberg , Philippe Ombredanne , Greg Kroah-Hartman , Kate Stewart , Thomas Gleixner , "David S. Miller" , Denys Vlasenko , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH 18/26] target/iscsi: Allocate session IDs from an IDA Message-ID: <20180731181510.GA16794@bombadil.infradead.org> References: <20180621212835.5636-1-willy@infradead.org> <20180621212835.5636-19-willy@infradead.org> <5B59FB56.9090901@redhat.com> <5B5A014D.9060901@redhat.com> <20180727193814.GB3825@bombadil.infradead.org> <5B5B892D.1000305@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 30, 2018 at 10:03:21PM -0400, Martin K. Petersen wrote: > > Mike, > > >> How about I take it through my tree to minimise the amount of rebasing > >> I'll need to do? I'm already dependent on the nvdimm tree and I'd rather > >> not depend on the scsi tree as well. I'll queue it up in front of my > >> IDA change to maximise its backportability. > > > > Ccing Martin, because he has been handling target patches. > > That's fine with me. > > Acked-by: Martin K. Petersen Thanks, Martin. Mike, can I have your Signed-off-by: on the original patch? What Fixes: line should this have? As far as I can tell, the bug is present all the way back to its introduction, so: Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1") yes?