Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 vulcan.natalenko.name 66CE03BCEF1
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 31 Jul 2018 20:34:31 +0200
From:   Oleksandr Natalenko <oleksandr@natalenko.name>
To:     kai.heng.feng@canonical.com
Cc:     arnd@arndb.de, bauer.chen@realtek.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
        ricky_wu@realtek.com, stern@rowland.harvard.edu,
        ulf.hansson@linaro.org
Subject: Re: [PATCH 0/5 v4] Keep rtsx_usb suspended when there's no card
In-Reply-To:  <<20180731061721.15831-1-kai.heng.feng@canonical.com>>
Message-ID: <17ae77968909919de05cdfb7d53ced3f@natalenko.name>
User-Agent: Roundcube Webmail/1.3.6
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi.

> Hi,
> 
> This is based on Ulf's work [1] [2].
> 
> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> platforms and ~1.5W on AMD platforms.
> 
> [1] https://patchwork.kernel.org/patch/10440583/
> [2] https://patchwork.kernel.org/patch/10445725/
> 
> Kai-Heng Feng (5):
>   misc: rtsx_usb: Use USB remote wakeup signaling for card insertion
>     detection
>   memstick: Prevent memstick host from getting runtime suspended during
>     card detection
>   memstick: rtsx_usb_ms: Use ms_dev() helper
>   memstick: rtsx_usb_ms: Support runtime power management
>   misc: rtsx_usb: / memstick: rtsx_usb_ms: Avoid long delay before
>     system suspend
> 
> v4: Use pm_runtime_put() in memstick_check().
> 
> v3: Skip parent device check in rtsx_usb_resume_child().
>     Remove dev_dbg() if it only prints function name.
>     Use ms_dev() helper at more places.
>     Remove const qualifier for UNIVERSAL_DEV_PM_OPS.
> 
> v2: Resend to linux-usb and LKML.
> 
> ---
> 
> Kai-Heng Feng (5):
>   misc: rtsx_usb: Use USB remote wakeup signaling for card insertion
>     detection
>   memstick: Prevent memstick host from getting runtime suspended during
>     card detection
>   memstick: rtsx_usb_ms: Use ms_dev() helper
>   memstick: rtsx_usb_ms: Support runtime power management
>   misc: rtsx_usb: / memstick: rtsx_usb_ms: Avoid long delay before
>     system suspend
> 
>  drivers/memstick/core/memstick.c    |   4 +
>  drivers/memstick/host/rtsx_usb_ms.c | 148 +++++++++++++++-------------
>  drivers/misc/cardreader/rtsx_usb.c  |   9 ++
>  3 files changed, 91 insertions(+), 70 deletions(-)
> 
> --
> 2.17.1

For the following device:

$ lsusb | grep Realtek
Bus 001 Device 004: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129 
Card Reader Controller

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>

No smoke.

Thanks.

-- 
   Oleksandr Natalenko (post-factum)