Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp5486860imm; Tue, 31 Jul 2018 11:45:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfYLbQufFAHJlIOSr8DRA6cTKeGjYN//T/NrUcPb/GOzrHLOV2WuSJT0ugTWXT6n4rtRcuC X-Received: by 2002:a17:902:4d45:: with SMTP id o5-v6mr10009068plh.78.1533062701664; Tue, 31 Jul 2018 11:45:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533062701; cv=none; d=google.com; s=arc-20160816; b=aq2qZb8Vzl1TWh21X7aQbprWOcocTN517mBJE+5phMJVced1bVz7xcln6u4gXWg6Ua 1267DFUTT3uDT+YPgaUyyMXVRJpznTKU8Irv692cmif+P1cE9fkBfKawlaUYJvyoJJlL wyAW8TamrV0fdykMaPrvN/VexY7kte57A6hD52SgUPTQttmD1uKimwSLAHq+jDEiWTJK O/3Dm0FkIv3CmzN9D5H2AHTihnrRUxHmvonspxtqS/FOqMxO+vdBgB8nYN4YmL0baBP1 Uf0QasMCndLAY0gvCaZkyVCR6kVaMGDuf03fZ0hxx0mHh3MwSSDF3sN1/WDHwt8TvWSH eGqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=0lQNNIM2ga1+GMhz0Ly/qfjikwFLYGqudZLw9gCQ1WI=; b=LThvfkzKl5K0L0Tu3FMGzcegIalsSFFQa/xVY7B6438iwt4MIa74mD8fPH4dfaaXZQ IawwB/LBQzZbPZJQRA1ANt/s5vG1yuFSCuZc142cST5SfoHbhZkuZS1cbh4Y7eYoZiqX 36DziSx9ABoHYVUTsVLH5jge3rtav46MGy4kTYnfL7KDdn71HCGyR7h3U2eSOWbLWsa1 X0cKyZ8cClawWuSNSmAUNkyxUfTO/oQou541/C8d04mWQK8Na+giT+B4fKl+gc5oqSl6 O2pytpsew2rkqVDc/XdO9nVuJ9G2l9eNIaHF9R4uQmpC4DiTTMVbtDpCbgvXI2pp5KXa cYPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18-v6si14006668pgd.448.2018.07.31.11.44.43; Tue, 31 Jul 2018 11:45:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731845AbeGaUZW (ORCPT + 99 others); Tue, 31 Jul 2018 16:25:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57520 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729772AbeGaUZW (ORCPT ); Tue, 31 Jul 2018 16:25:22 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F02187C6A9; Tue, 31 Jul 2018 18:43:45 +0000 (UTC) Received: from treble (ovpn-120-73.rdu2.redhat.com [10.10.120.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CACC7C5C; Tue, 31 Jul 2018 18:43:45 +0000 (UTC) Date: Tue, 31 Jul 2018 13:43:44 -0500 From: Josh Poimboeuf To: Jeremy Cline Cc: Jan Kara , linux-kernel@vger.kernel.org, Andreas Dilger Subject: Re: [PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets Message-ID: <20180731184344.yspy7sjbec74d5w6@treble> References: <20180731013731.1987-1-jcline@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180731013731.1987-1-jcline@redhat.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 31 Jul 2018 18:43:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 31 Jul 2018 18:43:46 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jpoimboe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 31, 2018 at 01:37:29AM +0000, Jeremy Cline wrote: > Hi folks, > > This series unifies XQM_MAXQUOTAS with MAXQUOTAS, which were both being > used to perform bounds checks on arrays, and then sanitizes 'type' so it > can't be used in speculative out-of-bounds array access. > > Jeremy Cline (2): > fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS > fs/quota: Fix spectre gadget in do_quotactl > > fs/quota/quota.c | 14 +++++++------- > include/linux/quota.h | 8 +------- > include/uapi/linux/dqblk_xfs.h | 5 ----- > 3 files changed, 8 insertions(+), 19 deletions(-) Looks good to me, though this might hinge on the discussion with Andreas: https://lkml.kernel.org/r/E3E7B6AF-3819-4998-9B12-DACB4EBC14F1@dilger.ca -- Josh