Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp155551imm; Tue, 31 Jul 2018 15:46:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpePZh38qR4sxdnwUvM/isvAAP6oObtAR/Ltdq4x/qKZDHnnLkdJDOeXvC1uO1mrQ9S0CD3V X-Received: by 2002:a62:d34a:: with SMTP id q71-v6mr23991499pfg.17.1533077188083; Tue, 31 Jul 2018 15:46:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533077188; cv=none; d=google.com; s=arc-20160816; b=XG/0lTSzZ18z3Yaz+z8OEAvmu6fzozTifvU+oksYYeTGeQTH/58TgfXDiheqb5bAIW 7pi9c2xR2rsytr2JKZ2IeCDParqylE18QsPGayM16B7FD2XFw4b9ORylcWa6sYWA0pfG UoNHw0T8YNlKRKb4U8YVE8K5mdqdEkZVG9epqqQ7J7IkQB+VqXdS/vh08hCjwgnEcq8B hDDKeRcpH6EbpEmgOUgtyi9TLC2d9bRVmD88iiSUabsuQC2Rhkf7/OVOqieXaV6g/I8a n0QCKnvmENwhxGGtSHxCSbTmTXzGc3WowAbVEMKtk0+UQhbo+VBPiG/XitGkWbOW+NR3 uJWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=XOud5IDkOekA2kTuU8wiHXB+F/ogtT2bVmQRTvLr9S4=; b=ZL2fzhRUxF1QrxXBSTTER/BYCwLT+tT5wac8MIDE/d1E/HKKSn1FY368QtGMfPcm13 HdU/N0j6JDjw3x+xz3Ytbim0nP/O077YGqazwWkcMhfMnc8IOzqN49u5Wey1SoFJ6xdc Y79N/4UPUJ1Q6sDd9JOMYSQfQh9mWnb/CoXwgss1dmMgA+c4ex31GqSm/pkq5znOXrGQ mOBxV8qIxJsMfwV7HlDxQqQBolDcEHnPZ28b//aqs8xCUEf9dpo3aU7l/Wgf8vPhxb3/ qqWBxRDIHHzbmT7Lgjz/oUb1Ajl2ItYk+g+ApjqV8z92zSQm7Oy1cSum//0cesqMKDqK IuBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=BIBKZuEv; dkim=pass header.i=@codeaurora.org header.s=default header.b=BebyPh2A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 144-v6si14167185pge.406.2018.07.31.15.46.13; Tue, 31 Jul 2018 15:46:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=BIBKZuEv; dkim=pass header.i=@codeaurora.org header.s=default header.b=BebyPh2A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732738AbeHAA1S (ORCPT + 99 others); Tue, 31 Jul 2018 20:27:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35952 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732563AbeHAA1R (ORCPT ); Tue, 31 Jul 2018 20:27:17 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D7DF060714; Tue, 31 Jul 2018 22:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533077084; bh=hIikZFeJwSAsQuu13Jv6oMfWXL41xeEyjfDNEyH8N4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BIBKZuEvdwHQIYT11bxSP0ihyzz/4JvPwewu+zGs2k5HreAFlg5rvHj3s5cLREtpX GvGQvLSEeey4FSF3F7OKFN11G2SlCeq897Kdy0ntq3iAd/fsw4VAE3gjR3r1D2BO4U HTIqStlyIaWQTIVZ0OdFPBgsGl2XAynUnLJGz0VM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from codeaurora.org (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BF05D60481; Tue, 31 Jul 2018 22:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1533077083; bh=hIikZFeJwSAsQuu13Jv6oMfWXL41xeEyjfDNEyH8N4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BebyPh2A768cftGd9S+fRmauVhybm6jQyV1vMRt6UKFqneu53gWxb7z3WMpbLO4Ga zhDMwymygvI6Cvloka/cOFgzXTG0tXmavmgw3cnkjxshvNPcHBIxlOwtaO2pYAm0CL paV3W9xy4PMbqD6Af+sxQhaQauxsYXZ5h3tt2+3w= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BF05D60481 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org From: Lina Iyer To: marc.zyngier@arm.com, sboyd@chromium.org, evgreen@chromium.org, linus.walleij@linaro.org, bjorn.andersson@linaro.org Cc: rplsssn@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, rnayak@codeaurora.org, devicetree@vger.kernel.org, Lina Iyer Subject: [PATCH RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO Date: Tue, 31 Jul 2018 16:44:18 -0600 Message-Id: <20180731224421.29062-2-ilina@codeaurora.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180731224421.29062-1-ilina@codeaurora.org> References: <20180731224421.29062-1-ilina@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to the its interrupt controller. Select GPIOs that are deemed wakeup capable are routed to specific PDC pins. The PDC wakes up the GIC and replays the interrupt at the GIC and the interrupt handler for the GPIO is invoked. Setup the PDC IRQ when the GPIO's IRQ is requested and enable the PDC IRQ when the GPIO's IRQ is enabled. Signed-off-by: Lina Iyer --- drivers/pinctrl/qcom/pinctrl-msm.c | 163 +++++++++++++++++++++++++++++ drivers/pinctrl/qcom/pinctrl-msm.h | 14 +++ 2 files changed, 177 insertions(+) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index 0e22f52b2a19..39c3934712f7 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -71,6 +71,13 @@ struct msm_pinctrl { const struct msm_pinctrl_soc_data *soc; void __iomem *regs; + struct list_head pdc_irqs; +}; + +struct wakeup_gpio_irq_map { + struct list_head list; + unsigned gpio; + unsigned pdc_irq; }; static int msm_get_groups_count(struct pinctrl_dev *pctldev) @@ -558,6 +565,39 @@ static void msm_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) #define msm_gpio_dbg_show NULL #endif +static int msm_gpio_get_pdc_pin(struct msm_pinctrl *pctrl, unsigned hwirq) +{ + struct msm_pinctrl_pdc_map *map = pctrl->soc->pdc_map; + int i; + + for (i = 0; i < pctrl->soc->npdc_pins; i++) { + if (map[i].hwirq == hwirq) + return map[i].pdc_pin; + } + + return -ENOTCONN; +} + +static struct irq_data *msm_get_pdc_irq_data(struct irq_data *d) +{ + struct wakeup_gpio_irq_map *p; + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); + struct msm_pinctrl *pctrl = gpiochip_get_data(gc); + struct irq_data *data = NULL; + unsigned long flags; + + raw_spin_lock_irqsave(&pctrl->lock, flags); + list_for_each_entry(p, &pctrl->pdc_irqs, list) { + if (p->gpio == d->hwirq) { + data = irq_get_irq_data(p->pdc_irq); + break; + } + } + raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return data; +} + static const struct gpio_chip msm_gpio_template = { .direction_input = msm_gpio_direction_input, .direction_output = msm_gpio_direction_output, @@ -687,6 +727,11 @@ static int msm_gpio_irq_set_type(struct irq_data *d, unsigned int type) const struct msm_pingroup *g; unsigned long flags; u32 val; + struct irq_data *pdc_irqd = msm_get_pdc_irq_data(d); + + // TODO: Lock PDC irq chip and set type? + if (pdc_irqd) + pdc_irqd->chip->irq_set_type(pdc_irqd, type); g = &pctrl->soc->groups[d->hwirq]; @@ -779,9 +824,13 @@ static int msm_gpio_irq_set_wake(struct irq_data *d, unsigned int on) struct gpio_chip *gc = irq_data_get_irq_chip_data(d); struct msm_pinctrl *pctrl = gpiochip_get_data(gc); unsigned long flags; + struct irq_data *pdc_irqd = msm_get_pdc_irq_data(d); raw_spin_lock_irqsave(&pctrl->lock, flags); + if (pdc_irqd) + irq_set_irq_wake(pdc_irqd->irq, on); + irq_set_irq_wake(pctrl->irq, on); raw_spin_unlock_irqrestore(&pctrl->lock, flags); @@ -863,6 +912,117 @@ static bool msm_gpio_needs_valid_mask(struct msm_pinctrl *pctrl) return device_property_read_u16_array(pctrl->dev, "gpios", NULL, 0) > 0; } +static irqreturn_t wake_irq_gpio_handler(int irq, void *data) +{ + struct irq_data *irqd = data; + struct irq_desc *desc = irq_data_to_desc(irqd); + struct irq_chip *chip = irq_desc_get_chip(desc); + struct gpio_chip *gc = irq_data_get_irq_chip_data(irqd); + int irq_pin = irq_find_mapping(gc->irq.domain, irqd->hwirq); + + chained_irq_enter(chip, desc); + generic_handle_irq(irq_pin); + chained_irq_exit(chip, desc); + + return IRQ_HANDLED; +} + +static int msm_gpio_pdc_pin_request(struct irq_data *d) +{ + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); + struct msm_pinctrl *pctrl = gpiochip_get_data(gc); + struct platform_device *pdev = to_platform_device(pctrl->dev); + unsigned pin, npins, irq; + struct wakeup_gpio_irq_map *p; + unsigned long flags, trigger; + const char *pin_name; + int i, ret; + + pin = msm_gpio_get_pdc_pin(pctrl, d->hwirq); + if (pin < 0) + return 0; + + npins = platform_irq_count(pdev); + if (npins <= 0) + return npins; + + for (i = 0; i < npins; i++) { + irq = platform_get_irq(pdev, i); + if (irq >= 0 && pin == irq_get_irq_data(irq)->hwirq) + break; + } + if (i == npins) + return 0; + + pin_name = kasprintf(GFP_KERNEL, "gpio-%lu", d->hwirq); + if (!pin_name) + return -ENOMEM; + + trigger = irqd_get_trigger_type(d) | IRQF_ONESHOT | IRQF_NO_SUSPEND; + ret = request_irq(irq, wake_irq_gpio_handler, trigger, pin_name, d); + if (ret) { + pr_warn("GPIO-%lu could not be set up as wakeup", d->hwirq); + return ret; + } + + p = kzalloc(sizeof(p), GFP_KERNEL); + if (!p) + return -ENOMEM; + + p->pdc_irq = irq; + p->gpio = d->hwirq; + raw_spin_lock_irqsave(&pctrl->lock, flags); + list_add(&p->list, &pctrl->pdc_irqs); + raw_spin_unlock_irqrestore(&pctrl->lock, flags); + + return 0; +} + +static int msm_gpio_pdc_pin_release(struct irq_data *d) +{ + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); + struct msm_pinctrl *pctrl = gpiochip_get_data(gc); + struct wakeup_gpio_irq_map *p, *n, *t = NULL; + unsigned long flags; + + raw_spin_lock_irqsave(&pctrl->lock, flags); + list_for_each_entry_safe(p, n, &pctrl->pdc_irqs, list) { + if (p->gpio == d->hwirq) { + list_del(&p->list); + t = p; + break; + } + } + raw_spin_unlock_irqrestore(&pctrl->lock, flags); + if (t) { + free_irq(t->pdc_irq, NULL); + kfree(t); + } + + return 0; +} + +static int msm_gpio_irq_reqres(struct irq_data *d) +{ + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); + + if (gpiochip_lock_as_irq(gc, irqd_to_hwirq(d))) { + dev_err(gc->parent,"unable to lock HW IRQ %lu for IRQ\n", + irqd_to_hwirq(d)); + return -EINVAL; + } + + return msm_gpio_pdc_pin_request(d); +} + +static void msm_gpio_irq_relres(struct irq_data *d) +{ + struct gpio_chip *gc = irq_data_get_irq_chip_data(d); + + msm_gpio_pdc_pin_release(d); + gpiochip_unlock_as_irq(gc, irqd_to_hwirq(d)); +} + static int msm_gpio_init(struct msm_pinctrl *pctrl) { struct gpio_chip *chip; @@ -887,6 +1047,9 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) pctrl->irq_chip.irq_ack = msm_gpio_irq_ack; pctrl->irq_chip.irq_set_type = msm_gpio_irq_set_type; pctrl->irq_chip.irq_set_wake = msm_gpio_irq_set_wake; + pctrl->irq_chip.irq_request_resources = msm_gpio_irq_reqres; + pctrl->irq_chip.irq_release_resources = msm_gpio_irq_relres; + INIT_LIST_HEAD(&pctrl->pdc_irqs); ret = gpiochip_add_data(&pctrl->chip, pctrl); if (ret) { diff --git a/drivers/pinctrl/qcom/pinctrl-msm.h b/drivers/pinctrl/qcom/pinctrl-msm.h index 9b9feea540ff..5b7f3160affe 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.h +++ b/drivers/pinctrl/qcom/pinctrl-msm.h @@ -97,6 +97,16 @@ struct msm_pingroup { unsigned intr_detection_width:5; }; +/** + * struct msm_pinctrl_pdc_map - Map GPIOs to PDC pins on RPMH based SoCs + * @hwirq: The GPIO that is mapped. + * @pdc_pin: The PDC pin to with the GPIO IRQ line is routed. + */ +struct msm_pinctrl_pdc_map { + u32 hwirq; + u32 pdc_pin; +}; + /** * struct msm_pinctrl_soc_data - Qualcomm pin controller driver configuration * @pins: An array describing all pins the pin controller affects. @@ -107,6 +117,8 @@ struct msm_pingroup { * @ngroups: The numbmer of entries in @groups. * @ngpio: The number of pingroups the driver should expose as GPIOs. * @pull_no_keeper: The SoC does not support keeper bias. + * @pdc_map: The map of GPIOs to the always-on PDC interrupt lines. + * @npdc_pins: The number of GPIOs mapped to the PDC pins in @pdc_map. */ struct msm_pinctrl_soc_data { const struct pinctrl_pin_desc *pins; @@ -117,6 +129,8 @@ struct msm_pinctrl_soc_data { unsigned ngroups; unsigned ngpios; bool pull_no_keeper; + struct msm_pinctrl_pdc_map *pdc_map; + unsigned npdc_pins; }; int msm_pinctrl_probe(struct platform_device *pdev, -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project